Added fix for wrong PATH to build-windows.md #10884

pull eliahuhorwitz wants to merge 1 commits into bitcoin:master from eliahuhorwitz:patch-1 changing 1 files +2 −0
  1. eliahuhorwitz commented at 8:36 pm on July 19, 2017: none
    Added fix for wrong PATH as seen here: https://github.com/bitcoin/bitcoin/issues/10269
  2. Update build-windows.md
    Added fix for wrong PATH as seen here:
    https://github.com/bitcoin/bitcoin/issues/10269
    2d373349bb
  3. laanwj added the label Windows on Jul 19, 2017
  4. laanwj added the label Docs and Output on Jul 19, 2017
  5. in doc/build-windows.md:72 in 2d373349bb
    68@@ -69,6 +69,7 @@ Then build using:
    69 
    70     cd depends
    71     make HOST=x86_64-w64-mingw32
    72+    #if the above line fails run this "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games"
    


    promag commented at 1:09 am on July 20, 2017:
    Could we change the instructions to never fail?
  6. in doc/build-windows.md:88 in 2d373349bb
    84@@ -84,6 +85,7 @@ Then build using:
    85 
    86     cd depends
    87     make HOST=i686-w64-mingw32
    88+    
    


    promag commented at 1:10 am on July 20, 2017:
    Unrelated?

    eliahuhorwitz commented at 5:07 am on July 20, 2017:
    Ta, my bad. Although I guess the 32 bit install will have the same problem so maybe add it here as well?

    laanwj commented at 8:28 am on July 20, 2017:
    That would be repeating the same thing twice, maybe it would be better to add a warning section describing the problem and solution, instead of buried in the instructions to type? (and possibly refer to that here)

    eliahuhorwitz commented at 8:34 am on July 20, 2017:
    Great, ill do that later, there are a few more things I need to add
  7. promag commented at 1:12 am on July 20, 2017: member

    Missing explanation on PR description.

    Nit, PR title and commit message should mention it’s a fix. Suggestion: Fix windows build instructions.

  8. laanwj renamed this:
    Update build-windows.md
    Added fix for wrong PATH to build-windows.md
    on Jul 25, 2017
  9. fanquake commented at 1:29 am on September 25, 2017: member
    Closing in favour of #11244.
  10. fanquake closed this on Sep 25, 2017

  11. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-22 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me