Fix constness of ArgsManager methods #10901

pull promag wants to merge 1 commits into bitcoin:master from promag:2017-07-args-manager-constness changing 2 files +29 −24

promag commented at 11:07 PM on July 21, 2017: member

Make cs_args mutex mutable so that const methods can acquire it.

There's also tiny performance improvement by avoiding two map lookups when retrieving an argument value.
fanquake added the label Refactoring on Jul 22, 2017
TheBlueMatt commented at 3:57 PM on July 24, 2017: member

Can you rebase without #10885 because of #10885 (comment) ? utACK the last commit by itself.
Fix constness of ArgsManager methods a622a17683
promag force-pushed on Jul 24, 2017
TheBlueMatt commented at 11:42 PM on July 24, 2017: member

utACK a622a1768325d01eeb16f42340cdd36e722a3fa8
sipa commented at 12:28 AM on July 25, 2017: member

utACK a622a1768325d01eeb16f42340cdd36e722a3fa8
dcousens approved
jonasschnelli commented at 7:16 AM on July 25, 2017: contributor

utACK a622a1768325d01eeb16f42340cdd36e722a3fa8
practicalswift commented at 3:34 PM on July 31, 2017: contributor

utACK a622a1768325d01eeb16f42340cdd36e722a3fa8 👍
promag commented at 3:09 PM on August 6, 2017: member

PR description updated.
paveljanik commented at 10:36 AM on August 11, 2017: contributor

utACK a622a17
MarcoFalke merged this on Aug 16, 2017
MarcoFalke closed this on Aug 16, 2017
MarcoFalke referenced this in commit 22e301a3d5 on Aug 16, 2017
PastaPastaPasta referenced this in commit 3dc7ebfcde on Sep 19, 2019
PastaPastaPasta referenced this in commit a87b919b09 on Sep 23, 2019
PastaPastaPasta referenced this in commit a259452fee on Sep 24, 2019
PastaPastaPasta referenced this in commit 92aa3793c7 on Nov 19, 2019
PastaPastaPasta referenced this in commit 1176eea1e9 on Nov 21, 2019
PastaPastaPasta referenced this in commit c0dab304c4 on Dec 9, 2019
PastaPastaPasta referenced this in commit f1ee83d4d5 on Jan 1, 2020
PastaPastaPasta referenced this in commit 243a19a2de on Jan 2, 2020
PastaPastaPasta referenced this in commit c1d6a7f5e9 on Jan 2, 2020
PastaPastaPasta referenced this in commit 03bd8266d9 on Jan 2, 2020
PastaPastaPasta referenced this in commit 34c1751477 on Jan 2, 2020
PastaPastaPasta referenced this in commit 7954cc3dbd on Jan 3, 2020
furszy referenced this in commit de5b240881 on Oct 28, 2020
ckti referenced this in commit 3270e3b39a on Mar 28, 2021
gades referenced this in commit 1dec439a6b on Jun 30, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels