This assures that we don't overwrite a random file called wallet.backup that happens to be in the current directory. It also assures that the temporary file will be cleaned up.
Noticed by Evan Klitzke, came up in discussion here: #10880 (review)
test: Make sure wallet.backup is created in temp path #10927
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2017_07_wallet_backup_temp_path changing 1 files +2 −2-
laanwj commented at 12:45 PM on July 25, 2017: member
-
88af227687
test: Make sure wallet.backup is created in temp path
This assures that we don't overwrite a random file called `wallet.backup` that happens to be in the current directory. It also assures that the temporary file will be cleaned up. Noticed by Evan Klitzke, came up in discussion here: https://github.com/bitcoin/bitcoin/pull/10880#discussion_r128460722
- laanwj added the label Tests on Jul 25, 2017
-
jonasschnelli commented at 12:58 PM on July 25, 2017: contributor
utACK 88af2276876868fc5b17a67ecaa86b219969d4c6
-
promag commented at 1:38 PM on July 25, 2017: member
utACK 88af227.
-
practicalswift commented at 1:54 PM on July 25, 2017: contributor
utACK 88af2276876868fc5b17a67ecaa86b219969d4c6
Excerpt from the
boost::filesystem::pathdocumentation for some context:The append operations use
operator/=to denote their semantic effect of appending the platform's preferred directory separator when needed. -
TheBlueMatt commented at 7:45 PM on July 25, 2017: member
utACK
-
MarcoFalke commented at 7:54 PM on July 25, 2017: member
Thanks! utACK 88af2276876868fc5b17a67ecaa86b219969d4c6
- laanwj merged this on Jul 25, 2017
- laanwj closed this on Jul 25, 2017
- laanwj referenced this in commit 9d5e8f92a7 on Jul 25, 2017
- PastaPastaPasta referenced this in commit 8fdf594316 on Aug 2, 2019
- PastaPastaPasta referenced this in commit fa2f4da949 on Aug 6, 2019
- barrystyle referenced this in commit 3f2c3cc79d on Jan 22, 2020
- DrahtBot locked this on Sep 8, 2021
