[tests] Test disconnecting unsupported service bits logic. #11001

1. 
   jnewbery commented at 3:41 PM on August 7, 2017: member

   In v0.15, we disconnect nodes that send us version messages with unsupported service bits (1 << 5 and 1 << 7). This commit adds a test that bitcoind will disconnect those nodes before August 1st 2018, and won't disconnect those nodes after August 1st 2018. @sdaftuar @TheBlueMatt

2. [tests] Test disconnecting unsupported service bits logic.

   In v0.15, we disconnect nodes that send us version messages with
   unsupported service bits (1 << 5 and 1 << 7). This commit adds a test
   that bitcoind will disconnect those nodes before August 1st 2018, and won't
   disconnect those nodes after August 1st 2018.

   5e35cd94c1
3. laanwj added the label Tests on Aug 7, 2017
4. 
   jnewbery commented at 3:54 PM on August 7, 2017: member

   @laanwj - should be tagged v0.15 since it's a regression test for #10982

5. 
   TheBlueMatt commented at 6:53 PM on August 7, 2017: member

   Thanks, looks good to me.

   On August 7, 2017 8:41:21 AM PDT, John Newbery notifications@github.com wrote:

   In v0.15, we disconnect nodes that send us version messages with unsupported service bits (1 << 5 and 1 << 7). This commit adds a test that bitcoind will disconnect those nodes before August 1st 2018, and won't disconnect those nodes after August 1st 2018.

   @sdaftuar @TheBlueMatt You can view, comment on, or merge this pull request online at:

   #11001

   -- Commit Summary --

   • [tests] Test disconnecting unsupported service bits logic.

   -- File Changes --

   M test/functional/p2p-leaktests.py (34) M test/functional/test_framework/mininode.py (2)

   -- Patch Links --

   https://github.com/bitcoin/bitcoin/pull/11001.patch https://github.com/bitcoin/bitcoin/pull/11001.diff

   -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/bitcoin/bitcoin/pull/11001

6. MarcoFalke added this to the milestone 0.15.0 on Aug 7, 2017
7. 
   MarcoFalke commented at 9:15 PM on August 7, 2017: member

   utACK 5e35cd94c18d81cbcc7fdece484822841ded402c

8. MarcoFalke merged this on Aug 7, 2017
9. MarcoFalke closed this on Aug 7, 2017

   ---

10. MarcoFalke referenced this in commit fa8a0639f7 on Aug 7, 2017
11. 
    ghost commented at 11:26 AM on August 9, 2017: none

    Why not relax the rule to instead allow for a maximum of e.g. 3 connections to nodes with the service bits 5 and 7? That way the network may stay fully connected both before and after a 2x HF in three months.

12. 
    MarcoFalke commented at 11:37 AM on August 9, 2017: member

    This was meant as a minimal fix/diff to be included in the first release candidate of 0.15.0, which was already due last Sunday. Beside the additional review required for more complex changes to p2p logic, it is unlikely that a more involved fix makes it into 0.15.0. Code cleanup for 0.16.0 is welcome, though.

13. jnewbery deleted the branch on Aug 9, 2017
14. 
    TheBlueMatt commented at 8:37 PM on August 9, 2017: member

    The 2x/Bitcoin networks will stay trivially connected through the next few months. There is no chance that everyone running 0.13/0.14 nodes will upgrade to 15 that quickly - we've never seen upgrades anywhere near that fast in the past, even when there was more incentive to do so.

    On August 9, 2017 4:26:17 AM PDT, bmagn notifications@github.com wrote:

    Why not relax the rule to instead allow for a maximum of e.g. 3 connections to nodes with the service bits 5 and 7? That way the network may stay fully connected both before and after a 2x HF in three months.

    -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/bitcoin/bitcoin/pull/11001#issuecomment-321227975

15. 
    jnewbery commented at 8:51 PM on August 9, 2017: member

    Please can we lock this PR? This PR added a new functional test case and is not the place to discuss the merits/demerits of the node disconnection behaviour in 10982. Thanks!

16. MarcoFalke referenced this in commit 42973f8344 on Sep 13, 2017
17. attilaaf referenced this in commit 4ffc9140a8 on May 25, 2019
18. PastaPastaPasta referenced this in commit 3fec5ef17c on Sep 24, 2019
19. PastaPastaPasta referenced this in commit 28f9b8b67c on Dec 21, 2019
20. PastaPastaPasta referenced this in commit d5fcfed522 on Jan 2, 2020
21. PastaPastaPasta referenced this in commit bc7b3574e5 on Jan 4, 2020
22. PastaPastaPasta referenced this in commit a6eb67bb90 on Jan 4, 2020
23. PastaPastaPasta referenced this in commit 0a65bf8cf3 on Jan 10, 2020
24. PastaPastaPasta referenced this in commit 14feeb8100 on Jan 10, 2020
25. PastaPastaPasta referenced this in commit 00167dea54 on Jan 10, 2020
26. PastaPastaPasta referenced this in commit b7837f02e0 on Jan 12, 2020
27. ckti referenced this in commit ddbd830d5a on Mar 28, 2021
28. gades referenced this in commit 9781144586 on Jun 30, 2021
29. DrahtBot locked this on Sep 8, 2021

Milestone
0.15.0