[Trivial] Add a comment on the use of prevector in script. #11011

pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:201708-prevector-comment changing 1 files +6 −0

gmaxwell commented at 10:54 PM on August 8, 2017: contributor

No description provided.
fanquake added the label Docs and Output on Aug 8, 2017

in src/script/script.h:384 in a9b952c9cb outdated

 376 | @@ -377,6 +377,12 @@ class CScriptNum
 377 |      int64_t m_value;
 378 |  };
 379 |  
 380 | +/**
 381 | + * We use a prevector for the script to reduce the considerable memory overhead
 382 | + *  of vectors in cases where they normally contain a small number of small elements.
 383 | + * Tests in October 2015 showed use of this reduced dbcache memory usage by 23%
 384 | + *  and and made an initial sync 13% faster.

paveljanik commented at 6:04 AM on August 9, 2017:

and and

kallewoof approved
instagibbs commented at 1:37 PM on August 11, 2017: member

ACK(and and aside), very helpful!
sdaftuar commented at 2:56 PM on August 11, 2017: member

ACK (apart from @paveljanik's nit)
fanquake commented at 1:32 PM on August 12, 2017: member

utACK post nit
[Trivial] Add a comment on the use of prevector in script. 08f71c29ea

in src/script/script.h:381 in 08f71c29ea

 376 | @@ -377,6 +377,12 @@ class CScriptNum
 377 |      int64_t m_value;
 378 |  };
 379 |  
 380 | +/**
 381 | + * We use a prevector for the script to reduce the considerable memory overhead

promag commented at 12:23 AM on August 15, 2017:

nanonit: * Use a prevector ...

MarcoFalke merged this on Aug 15, 2017
MarcoFalke closed this on Aug 15, 2017
MarcoFalke referenced this in commit 7db65c363a on Aug 15, 2017
PastaPastaPasta referenced this in commit ae25cb7d0d on Sep 19, 2019
PastaPastaPasta referenced this in commit 89dd77fe3a on Sep 23, 2019
PastaPastaPasta referenced this in commit d57fd7c758 on Sep 24, 2019
PastaPastaPasta referenced this in commit 88f5060424 on Nov 19, 2019
PastaPastaPasta referenced this in commit a4a6e92fc4 on Nov 21, 2019
PastaPastaPasta referenced this in commit b7af9ee69a on Dec 9, 2019
PastaPastaPasta referenced this in commit 2e8e319721 on Jan 1, 2020
PastaPastaPasta referenced this in commit 972a0498e7 on Jan 2, 2020
Fuzzbawls referenced this in commit 8dfc4806f7 on May 19, 2020
ckti referenced this in commit d2244dbf48 on Mar 28, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels