Remove unused imports (script.OP_0 and script.sha256).
[tests] Remove unused imports (script.OP_0 and script.sha256) #11190
pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:remove-unused-import-op_0 changing 1 files +1 −1-
practicalswift commented at 11:14 AM on August 29, 2017: contributor
- practicalswift renamed this:
[tests] Remove unused imports (script.OP_0 and script.sha256)
[tests] Remove unused imports (script.OP_0 and script.sha256). Fix typo.
on Aug 29, 2017 -
[tests] Remove unused imports (script.{OP_0,sha256}) c7e0abe190
- practicalswift force-pushed on Aug 29, 2017
-
meshcollider commented at 11:35 AM on August 29, 2017: contributor
The typo fix is wrong unfortunately, should be 'a' (because 'one' effectively starts with a 'w')
- fanquake added the label Tests on Aug 29, 2017
-
fanquake commented at 12:29 PM on August 29, 2017: member
Agree with @MeshCollider that the typo fix isn't correct.
- practicalswift force-pushed on Aug 29, 2017
- practicalswift renamed this:
[tests] Remove unused imports (script.OP_0 and script.sha256). Fix typo.
[tests] Remove unused imports (script.OP_0 and script.sha256)
on Aug 29, 2017 -
practicalswift commented at 1:20 PM on August 29, 2017: contributor
@MeshCollider @fanquake Thanks for reviewing! Typo fix removed :-) What about the remaining import fix? ACK? :-)
-
meshcollider commented at 8:35 PM on August 30, 2017: contributor
Yeah Concept ACK for removing the unused import
-
jnewbery commented at 3:52 PM on September 1, 2017: member
There are many instances in the test/functional/test_framework directory of unused imports, wildcard imports, names being imported indirectly through wildcard imports, imports on the same line, imports not in PEP8 ordering, imports not being sorted, etc.
I'd rather have a single PR that fixes all of those nits, rather than tackle it file-by-file.
That said, utACK c7e0abe1904bac179771985c5223a323a17f97f5 if people disagree with my preferred approach.
-
MarcoFalke commented at 4:28 PM on September 1, 2017: member
Agree with @jnewbery if a fix is reasonable to do for the whole project in a single commit, that should be preferred. However, if that is not feasible for whatever reason or not worth it, nothing should be touched. (Unless you need to change the line anyway.)
- practicalswift closed this on Sep 1, 2017
- practicalswift deleted the branch on Apr 10, 2021
- DrahtBot locked this on Aug 18, 2022
Labels