Docs: Add extra step to clean $PATH var to strip out windows %PATH% paths. #11244

1. 
   donaloconnor commented at 8:57 pm on September 5, 2017: contributor

   I experienced the same ( error mentioned in #10269) . The suggested extra step in this PR removes the problematic Windows paths from the $PATH var.
2. 
   donaloconnor commented at 9:05 pm on September 5, 2017: contributor

   I am not sure if version Ubuntu Trusty 14.04 pulls in the Windows %PATH% variable? I am using the latest Ubuntu Xenial 16.04 which has more issues cross compiling as mentioned in #10269 . If 14.04 does not pull in %PATH% thus not causing the issue this doc addition tries to fix then please reject this PR.

   Thanks.

3. 
   laanwj commented at 9:19 pm on September 5, 2017: member

   Overlaps with #10889
4. laanwj added the label Docs and Output on Sep 5, 2017
5. laanwj added the label Windows on Sep 5, 2017
6. 
   laanwj commented at 10:20 pm on September 6, 2017: member

   I am not sure if version Ubuntu Trusty 14.04 pulls in the Windows %PATH% variable?

   Not sure either, it doesn’t hurt to add the step in any case, it will likely still be needed for 18.04.

7. 
   fanquake commented at 3:34 am on September 8, 2017: member

   Started testing this. Built master at https://github.com/bitcoin/bitcoin/commit/c22a53cd6351b3f0e96de971b001ad712b83fc47 on a Windows 10 VM (Version 1607, OS Build 14393.1593) using WSL with Ubuntu 14.04.

   Going to upgrade to Ubuntu 16.04/10 and test.

8. 
   fanquake commented at 1:06 am on September 9, 2017: member

   Upgraded WSL to 16.04.3, and tried building https://github.com/bitcoin/bitcoin/commit/c22a53cd6351b3f0e96de971b001ad712b83fc47 using these instructions. The result is as expected.

   Upgraded WSL to 17.04 and tried building https://github.com/bitcoin/bitcoin/commit/3255d6347b1f9eccbec3d6d93d4a424087a3b35b using these instructions + @laanwj’s info from #8732. That works successfully.

   I think it’d be worthwhile adding the posix alternative info to the readme, or at least mentioning that 17.04 will work with a simple workaround, given how many issues we’ve seen over the past few months.

9. 
   fanquake commented at 8:50 am on October 2, 2017: member

   @donaloconnor I’d like to cherry-pick this commit, but I can’t seem to as the author info is missing.

   0bitcoin xxx$ git cherry-pick 6e6ee9e83c35189fc98da5461633ef8aa5aa5879
   1fatal: empty ident name (for <user@xxx.localdomain>) not allowed
   

   Could you either push up a commit with author information, or do you mind if I take the changes as they are, and credit you in my new commit?

10. Add new step to clean $PATH var by removing /mnt specific Window's %PATH% paths that cause issues with the make system e66c2b4ecb
11. donaloconnor force-pushed on Oct 2, 2017
12. 
    donaloconnor commented at 10:24 am on October 2, 2017: contributor

    @fanquake - I think it should be okay now? I’m still getting my head around git so apologies if this doesn’t work. If it doesn’t then I’m good with credit in your commit.

    Cheers. Donal

13. 
    fanquake commented at 11:30 am on October 2, 2017: member

    @donaloconnor Thanks. Closing this PR in favour of #11437.
14. fanquake closed this on Oct 2, 2017

    ---

15. laanwj referenced this in commit becbd71b0c on Oct 5, 2017
16. codablock referenced this in commit 08513bfffd on Sep 25, 2019
17. charlesrocket referenced this in commit d048e5e900 on Dec 15, 2019
18. barrystyle referenced this in commit 785278ecd1 on Jan 22, 2020
19. DrahtBot locked this on Sep 8, 2021

Contributors
donaloconnor laanwj fanquake

Labels
Docs Windows