Issues in 'make distcheck' #11302

issue danra opened this issue on September 11, 2017
  1. danra commented at 4:47 PM on September 11, 2017: contributor

    Describe the issue

    Encountered a couple of issues encountered running "make distcheck" on my machine:

    1. During the build, getting a request to override read-only file attributes of qt/temp_bitcoin_locale.qrc
    2. At the end of the build, there's an error because of a leftover ./src/bench/data/block413567.raw.h file.

    Can you reliably reproduce the issue?

    Yes

    If so, please list the steps to reproduce below:

    1. Start with a clean master checkout
    2. Run ./autogen.sh
    3. Run ./configure
    4. Run make distcheck

    Expected behaviour

    No error at end and no request for manual confirmation of overriding read-only attributes during build

    Actual behaviour

    As described above. Output pasted in https://pastebin.com/2YEpeB5y

    What version of bitcoin-core are you using?

    ee50c9e48786dea0d9df2e45805c25565c100fe3

    Machine specs:

    • OS: macOS 10.12.6
  2. fanquake added the label MacOSX on Sep 12, 2017
  3. fanquake commented at 3:23 AM on October 7, 2017: member

    Just tested this with https://github.com/bitcoin/bitcoin/commit/17f2acedbe078f179556f4550eca547726f087e1 Seeing the override

      GEN      qt/qrc_bitcoin_locale.cpp
    override r--r--r--  xxx/staff for qt/temp_bitcoin_locale.qrc?   CXX      qt/test/qt_test_test_bitcoin_qt-compattests.o
      CXX      qt/test/qt_test_test_bitcoin_qt-rpcnestedtests.o
    

    but the bench issue(fixed in #11435?) was replaced with:

    rm -f cscope.out cscope.in.out cscope.po.out cscope.files
    test . = "../.." || test -z "contrib/filter-lcov.py test/functional/test_runner.py test/util/bitcoin-util-test.py" || rm -f contrib/filter-lcov.py test/functional/test_runner.py test/util/bitcoin-util-test.py
    rm -f config.status config.cache config.log configure.lineno config.status.lineno
    rm -f Makefile
    ERROR: files left in build directory after distclean:
    ./src/qt/temp_bitcoin_locale.qrc
    make[1]: *** [distcleancheck] Error 1
    make: *** [distcheck] Error 1
    
  4. jonasschnelli commented at 5:36 AM on October 7, 2017: contributor

    Yes. The bench clean issue is fixed in master. The override is present but not really problematic IMO.

  5. bmoo0 commented at 9:23 PM on November 6, 2017: none

    I'm getting make: *** No rule to make target distcheck'. Stop.`

    When trying to run make distcheck, has this been removed?

  6. MarcoFalke commented at 5:26 PM on November 7, 2017: member

    Closing, since the issue is fixed. Please open a new issue if anything needs to be addressed.

  7. MarcoFalke closed this on Nov 7, 2017

  8. laanwj referenced this in commit 1f7695b419 on Nov 17, 2017
  9. PastaPastaPasta referenced this in commit 626c74e82f on Jan 31, 2020
  10. PastaPastaPasta referenced this in commit 5b3744f60e on Feb 4, 2020
  11. PastaPastaPasta referenced this in commit b84b36f228 on Feb 9, 2020
  12. ckti referenced this in commit ce07df1bdc on Mar 28, 2021
  13. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me