laanwj
commented at 1:27 PM on November 13, 2017:
member
I don't think it hurts to add it to CLEANFILES just in case, but yes that is weird.
theuni
commented at 6:35 PM on November 14, 2017:
member
Sure, adding it as a backup is fine. It'd just be helpful to know why it's sticking around, as I'm not sure how that could happen.
@fanquake Mind changing this to CLEAN_QT in Makefile.qt.include instead? utACK after that.
[build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distchecka7c949f644
fanquake force-pushed on Nov 15, 2017
fanquake
commented at 12:24 AM on November 15, 2017:
member
Still not sure what is making it hang around. Maybe permissions related?
GEN qt/qrc_bitcoin_locale.cpp
override r--r--r-- xxx/staff for qt/temp_bitcoin_locale.qrc?
``
fanquake renamed this: [build] Add temp_bitcoin_locale_qrc to CLEANFILES to fix make distcheck [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck on Nov 15, 2017
theuni
commented at 4:33 PM on November 15, 2017:
member
@fanquake ah yes, that must be it. distcheck makes all files read-only, I guess the parent dir ends up with a umask set.
There's a cleaner way to handle this using the .INTERMEDIATE target, but it's not really worth the effort here.
theuni approved
theuni
commented at 4:35 PM on November 15, 2017:
member
utACKa7c949f644d82a5b97617256fa5e8cc511b8aa5f
laanwj merged this on Nov 17, 2017
laanwj closed this on Nov 17, 2017
laanwj referenced this in commit 1f7695b419 on Nov 17, 2017
fanquake deleted the branch on Jan 22, 2020
PastaPastaPasta referenced this in commit 626c74e82f on Jan 31, 2020
PastaPastaPasta referenced this in commit 5b3744f60e on Feb 4, 2020
PastaPastaPasta referenced this in commit b84b36f228 on Feb 9, 2020
ckti referenced this in commit ce07df1bdc on Mar 28, 2021
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-04-21 21:15 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me