[build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck #11621

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:fix-osx-distcheck changing 1 files +1 −1
  1. fanquake commented at 2:34 PM on November 6, 2017: member

    Fixes #11302

    Tested on OS X 10.12.6 with 0e707919f596c80056bca295abd71543ccae4956

    Was failing like:

    make distclean
    ....
    rm -f config.status config.cache config.log configure.lineno config.status.lineno
    rm -f Makefile
    ERROR: files left in build directory after distclean:
    ./src/qt/temp_bitcoin_locale.qrc
    make[1]: *** [distcleancheck] Error 1
    make: *** [distcheck] Error 1
    
  2. fanquake added the label Build system on Nov 6, 2017
  3. fanquake requested review from theuni on Nov 6, 2017
  4. promag commented at 1:11 AM on November 7, 2017: member

    utACK c52c0cd.

  5. theuni commented at 7:15 PM on November 7, 2017: member

    @fanquake This should be removed as soon as it's created: https://github.com/fanquake/bitcoin/blob/c52c0cdc8964d506e083d7cbc4fe6514f7398175/src/Makefile.qt.include#L430

    Any idea what's keeping it around for you?

  6. laanwj commented at 1:27 PM on November 13, 2017: member

    I don't think it hurts to add it to CLEANFILES just in case, but yes that is weird.

  7. theuni commented at 6:35 PM on November 14, 2017: member

    Sure, adding it as a backup is fine. It'd just be helpful to know why it's sticking around, as I'm not sure how that could happen. @fanquake Mind changing this to CLEAN_QT in Makefile.qt.include instead? utACK after that.

  8. [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck a7c949f644
  9. fanquake force-pushed on Nov 15, 2017
  10. fanquake commented at 12:24 AM on November 15, 2017: member

    @theuni Rebased and updated to use CLEAN_QT

    Still not sure what is making it hang around. Maybe permissions related?

      GEN      qt/qrc_bitcoin_locale.cpp
    override r--r--r--  xxx/staff for qt/temp_bitcoin_locale.qrc? 
    ``
    
  11. fanquake renamed this:
    [build] Add temp_bitcoin_locale_qrc to CLEANFILES to fix make distcheck
    [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck
    on Nov 15, 2017
  12. theuni commented at 4:33 PM on November 15, 2017: member

    @fanquake ah yes, that must be it. distcheck makes all files read-only, I guess the parent dir ends up with a umask set.

    There's a cleaner way to handle this using the .INTERMEDIATE target, but it's not really worth the effort here.

  13. theuni approved
  14. theuni commented at 4:35 PM on November 15, 2017: member

    utACK a7c949f644d82a5b97617256fa5e8cc511b8aa5f

  15. laanwj merged this on Nov 17, 2017
  16. laanwj closed this on Nov 17, 2017

  17. laanwj referenced this in commit 1f7695b419 on Nov 17, 2017
  18. fanquake deleted the branch on Jan 22, 2020
  19. PastaPastaPasta referenced this in commit 626c74e82f on Jan 31, 2020
  20. PastaPastaPasta referenced this in commit 5b3744f60e on Feb 4, 2020
  21. PastaPastaPasta referenced this in commit b84b36f228 on Feb 9, 2020
  22. ckti referenced this in commit ce07df1bdc on Mar 28, 2021
  23. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me