Trivial: Fix validation comments #11340

pull danra wants to merge 1 commits into bitcoin:master from danra:patch-12 changing 3 files +8 −9

danra commented at 10:44 AM on September 15, 2017: contributor
- Move comment about transaction/block weight calculation so it applies not only to the GetBlockWeight function but also to GetTransactionWeight
- Fix comment in validation.cpp referencing future deployment of BIP113. It has already been deployed.
- The doc comment for BLOCK_DOWNLOAD_WINDOW wasn't updated since pruning was introduced, so it still refers to pruning as something that might happen in the future. A larger BLOCK_DOWNLOAD_WINDOW window would now, indeed, make pruning harder.
meshcollider commented at 10:53 AM on September 15, 2017: contributor

Could you squash this into #11331 along with #11328? Would be cleaner to have all these small comment fixes in one commit

Trivial: Fix validation comments

- Move comment about transaction/block weight calculation so it applies not only to the GetBlockWeight function but also to GetTransactionWeight
- Fix comment in validation.cpp referencing future deployment of BIP113. It has already been deployed.
- The doc comment for BLOCK_DOWNLOAD_WINDOW wasn't updated since pruning was introduced, so it still refers to pruning as something that might happen in the future. A larger BLOCK_DOWNLOAD_WINDOW window would now, indeed, make pruning harder.

a0b4c24617

danra force-pushed on Sep 15, 2017
danra renamed this:
~~Trivial: Fix validation.cpp comment, BIP113 already deployed~~
Trivial: Fix validation comments
on Sep 15, 2017
danra commented at 11:10 AM on September 15, 2017: contributor

@MeshCollider Done
meshcollider commented at 11:13 AM on September 15, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/pull/11340/commits/a0b4c2461724e9ec70e6cd3e36929c9270ffcebd, remember to close the other PRs :)
danra commented at 11:15 AM on September 15, 2017: contributor

@MeshCollider Done, thanks for the reminder :)
fanquake added the label Docs and Output on Sep 15, 2017
practicalswift commented at 12:38 PM on September 15, 2017: contributor

utACK a0b4c2461724e9ec70e6cd3e36929c9270ffcebd
gmaxwell approved
gmaxwell commented at 9:00 AM on September 18, 2017: contributor

utACK
MarcoFalke merged this on Sep 18, 2017
MarcoFalke closed this on Sep 18, 2017
MarcoFalke referenced this in commit d6d2c8503c on Sep 18, 2017
PastaPastaPasta referenced this in commit f25a6555c4 on Dec 22, 2019
PastaPastaPasta referenced this in commit 44bc459274 on Jan 2, 2020
PastaPastaPasta referenced this in commit dde26f3361 on Jan 4, 2020
PastaPastaPasta referenced this in commit b27ef14ab2 on Jan 4, 2020
PastaPastaPasta referenced this in commit e75b1486e2 on Jan 10, 2020
PastaPastaPasta referenced this in commit 3706bcfb1d on Jan 10, 2020
PastaPastaPasta referenced this in commit 218f65d208 on Jan 10, 2020
PastaPastaPasta referenced this in commit 754da6005a on Jan 12, 2020
ckti referenced this in commit 7e149930ee on Mar 28, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels