Small refactor of CCoinsViewCache::BatchWrite() #11353

std::unordered_map::erase( const_iterator pos ) returns an iterator to the element following the removed one. Use that to optimize (probably minor-performance-wise, and definitely code-structure-wise) the implementation of CCoinsViewCache::BatchWrite().

Note to reviewers, most of the diff is indentation change, so use ?w=1

Other than adding missing braces to some if-statements which is a style only change, basically all this change does is move the erasure from mapIndex from the end of the loop body into the brackets. @danra small changes like this aren't really that useful to be perfectly honest sorry, its time consuming to review things like this with almost no real benefit to it. It would be a lot more helpful if you wanted to help out in reviewing other, bigger PRs which are blockers for releases, since you obviously know the standards fairly well :)

@MeshCollider Thanks, adding ?w=1 makes it look like a much more trivial refactor.

utACK 5b9748f979dd65b229e2882e670794c46e2e720b

ACK.

IMO the only good change here is it = mapCoins.erase(it). Adding braces because indentation, and indentation because of an early continue doesn't sound worth it. Don't get me wrong, but there are lots of other possible refactors like these and I think we don't want that to happen.

That said, NACK as it is.

@promag If it weren't for the move of the erase into the afterthought I would have also been with you. Since it was being changed I think fixing up the indentation is OKAY.

@MeshCollider

It would be a lot more helpful if you wanted to help out in reviewing other, bigger PRs which are blockers for releases, since you obviously know the standards fairly well :)

I will/am. I'm posting smaller fixes as I'm learning the code.

its time consuming to review things like this with almost no real benefit to it.

Improving both the conciseness and the structure of the code, making it more accessible and easy to reason about, does have real benefit IMHO. @promag The main change isn't the indentation, it's the more concise erase operation done in the for loop. Reducing indentation was a bonus.

utACK 5b9748f979dd65b229e2882e670794c46e2e720b

utACK 5b9748f97