Remove unused fTry from push_lock #11432

pull promag wants to merge 1 commits into bitcoin:master from promag:2017-08-clean-push-lock changing 1 files +2 −2

promag commented at 9:54 PM on September 30, 2017: member

After #9674 (618ee92) the fTry argument in push_lock is no longer needed.
Remove unused fTry from push_lock 92848e5058
promag commented at 9:55 PM on September 30, 2017: member

@TheBlueMatt FYI.
meshcollider commented at 9:59 PM on September 30, 2017: contributor

utACK https://github.com/bitcoin/bitcoin/commit/92848e5058c7667c61c358ea2c46f07a6edc468b
dcousens approved
MarcoFalke added the label Refactoring on Oct 1, 2017
MarcoFalke commented at 7:42 AM on October 1, 2017: member

utACK 92848e5058c7667c61c358ea2c46f07a6edc468b
fanquake commented at 11:09 AM on October 1, 2017: member

utACK 92848e5
laanwj merged this on Oct 2, 2017
laanwj closed this on Oct 2, 2017
laanwj referenced this in commit 058c0f996b on Oct 2, 2017
jnewbery commented at 2:46 PM on October 2, 2017: member

post-merge ACK 92848e5058c7667c61c358ea2c46f07a6edc468b

follow-up question: Is there any need for the member variable fTry in CLockLocation? If not, can we remove that and also the fTry argument in EnterCritical()?
PastaPastaPasta referenced this in commit fa7c71ac02 on Dec 22, 2019
PastaPastaPasta referenced this in commit aaae79b0f8 on Jan 2, 2020
PastaPastaPasta referenced this in commit 35c7897cb8 on Jan 4, 2020
PastaPastaPasta referenced this in commit 7a1bc16cab on Jan 12, 2020
PastaPastaPasta referenced this in commit c6c35849c7 on Jan 12, 2020
PastaPastaPasta referenced this in commit 0e7ceed105 on Jan 12, 2020
PastaPastaPasta referenced this in commit de032e62ed on Jan 12, 2020
PastaPastaPasta referenced this in commit f0b901d363 on Jan 12, 2020
PastaPastaPasta referenced this in commit 46a1ad7939 on Jan 12, 2020
ckti referenced this in commit a6b28229f2 on Mar 28, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#9674 Always enforce strict lock ordering (try or not)