Build: Fix Automake warnings when running autogen.sh #11541

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:fix-automake-warnings changing 3 files +1 −5

fanquake commented at 4:26 AM on October 21, 2017: member
Adjusted @eklitzke's commit to completely remove GZIP_ENV. Added a commit to address OBJCXXFLAGS. Rebased on master. Relevant info from @theuni & #11013 below.

GZIP_ENV was indeed added for determinism, but gitian exports this as needed, so it's not really necessary. I'd rather just remove it.

The mm.o rule was added to support XCode 4.2's ancient version of automake. That's irrelevant now, so it makes sense to remove that too.

All darwin targets are PIE by default, so we don't technically need the flags, but I'd be more comfortable if we hooked up the OBJCXXFLAGS in case future ones are added.

The second commit addresses the last point, but could probably use a better commit message. These warnings are removed from autogen output:
```
Makefile.am:12: warning: user variable 'GZIP_ENV' defined here ...
/usr/local/Cellar/automake/1.15.1/share/automake-1.15/am/distdir.am: ... overrides Automake variable 'GZIP_ENV' defined here
src/Makefile.am: installing 'build-aux/depcomp'
src/Makefile.am:503: warning: user target '.mm.o' defined here ...
/usr/local/Cellar/automake/1.15.1/share/automake-1.15/am/depend2.am: ... overrides Automake target '.mm.o' defined here
```
Fix automake warnings when running autogen.sh f8c66972dd
[Build] Add AM_OBJCXXFLAGS and QT_PIE_FLAGS to OBJCXXFLAGS to future-proof darwin targets cc5c39ddca
fanquake added the label Build system on Oct 21, 2017
fanquake requested review from theuni on Oct 21, 2017

paveljanik commented at 6:06 AM on October 21, 2017: contributor

Comparing #11541 build log to the master:

--- /tmp/master.log	2017-10-21 07:28:15.000000000 +0200
+++ /tmp/11541.log	2017-10-21 07:44:01.000000000 +0200
@@ -45,11 +45,7 @@
 configure.ac:28: installing 'build-aux/config.sub'
 configure.ac:38: installing 'build-aux/install-sh'
 configure.ac:38: installing 'build-aux/missing'
-Makefile.am:12: warning: user variable 'GZIP_ENV' defined here ...
-/opt/local/share/automake-1.15/am/distdir.am: ... overrides Automake variable 'GZIP_ENV' defined here
 src/Makefile.am: installing 'build-aux/depcomp'
-src/Makefile.am:503: warning: user target '.mm.o' defined here ...
-/opt/local/share/automake-1.15/am/depend2.am: ... overrides Automake target '.mm.o' defined here
 parallel-tests: installing 'build-aux/test-driver'
 checking build system type... x86_64-apple-darwin14.5.0
 checking host system type... x86_64-apple-darwin14.5.0

ACK https://github.com/bitcoin/bitcoin/pull/11541/commits/cc5c39ddca4cf5e01c45fdf69462f50ac984e264

theuni approved
theuni commented at 8:17 PM on October 24, 2017: member

Thanks for following up.

utACK cc5c39ddca4cf5e01c45fdf69462f50ac984e264
laanwj commented at 5:27 PM on October 29, 2017: member

utack cc5c39d
laanwj merged this on Oct 29, 2017
laanwj closed this on Oct 29, 2017
laanwj referenced this in commit bb9ab0fccf on Oct 29, 2017
PastaPastaPasta referenced this in commit b0de1bc7e9 on Dec 22, 2019
PastaPastaPasta referenced this in commit 493c08aefe on Jan 2, 2020
PastaPastaPasta referenced this in commit 0a0f20f644 on Jan 4, 2020
PastaPastaPasta referenced this in commit fea865b192 on Jan 12, 2020
PastaPastaPasta referenced this in commit c1f7a628d8 on Jan 12, 2020
PastaPastaPasta referenced this in commit 115a35b1e0 on Jan 12, 2020
PastaPastaPasta referenced this in commit 188b6294c5 on Jan 12, 2020
PastaPastaPasta referenced this in commit 3b55ddfda3 on Jan 12, 2020
PastaPastaPasta referenced this in commit d98bd92123 on Jan 12, 2020
PastaPastaPasta referenced this in commit 2f61a2007a on Jan 16, 2020
fanquake deleted the branch on Jan 22, 2020
ckti referenced this in commit b7050bc9f4 on Mar 28, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#11013 Build: Fix Automake warnings when running autogen.sh