"If a pull request is not to be considered for merging (yet), please prefix the ..."
If a particular commit references another issue, please add the reference. For example:
refs [#1234](/bitcoin-bitcoin/1234/)orfixes [#4321](/bitcoin-bitcoin/4321/).
Fixed a couple small grammatical errors. #11571
pull BitsInMyBlood wants to merge 1 commits into bitcoin:master from BitsInMyBlood:patch-1 changing 1 files +3 −3-
BitsInMyBlood commented at 8:24 PM on October 28, 2017: contributor
-
f927ee1aa8
Fixed a couple small grammatical errors.
1. "If a pull request is not to be considered for merging (yet), please prefix the ..." 2. If a particular commit references another issue, please add the reference. For example: `refs #1234` or `fixes #4321`.
- fanquake added the label Docs and Output on Oct 28, 2017
-
fanquake commented at 5:47 AM on October 29, 2017: member
utACK f927ee1
-
promag commented at 8:56 PM on October 29, 2017: member
utACK f927ee1.
Nit, could drop the period from commit message and PR title. There is no need to detail the commit message too (patch is pretty simple).
-
BitsInMyBlood commented at 9:40 PM on October 29, 2017: contributor
Forgive me, I'm new to contributing and am just trying to help. Any advice is encouraged and appreciated.
On Sun, Oct 29, 2017 at 1:57 PM, João Barbosa notifications@github.com wrote:
utACK f927ee1 https://github.com/bitcoin/bitcoin/commit/f927ee1aa871b1bd4c5ab2b218d0ea27ef9fff19 .
Nit, could drop the period from commit message and PR title. There is no need to detail the commit message too (patch is pretty simple).
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/11571#issuecomment-340293917, or mute the thread https://github.com/notifications/unsubscribe-auth/AFpjairxdnUw4TziOClegi_DffI3pMcxks5sxOa8gaJpZM4QKFGm .
-
practicalswift commented at 9:36 AM on October 30, 2017: contributor
ACK f927ee1aa871b1bd4c5ab2b218d0ea27ef9fff19. Nice first-time contribution!
-
BitsInMyBlood commented at 6:02 PM on October 30, 2017: contributor
You have no idea how appreciated your response is...
On Mon, Oct 30, 2017 at 2:37 AM, practicalswift notifications@github.com wrote:
utACK f927ee1 https://github.com/bitcoin/bitcoin/commit/f927ee1aa871b1bd4c5ab2b218d0ea27ef9fff19. Nice first-time contribution!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/11571#issuecomment-340391008, or mute the thread https://github.com/notifications/unsubscribe-auth/AFpjasGGTThMlC3HuGM5WuO2_wHS5myFks5sxZjagaJpZM4QKFGm .
-
meshcollider commented at 3:51 AM on October 31, 2017: contributor
-
laanwj commented at 1:22 PM on November 1, 2017: member
ACK f927ee1
- laanwj merged this on Nov 1, 2017
- laanwj closed this on Nov 1, 2017
- laanwj referenced this in commit c95832da87 on Nov 1, 2017
-
BitsInMyBlood commented at 7:20 PM on November 2, 2017: contributor
Deleting deprecated branch due to merge
- BitsInMyBlood deleted the branch on Nov 2, 2017
- PastaPastaPasta referenced this in commit 9d7a79baa3 on Dec 22, 2019
- PastaPastaPasta referenced this in commit d2b7e2b7c1 on Jan 2, 2020
- PastaPastaPasta referenced this in commit af332ed2ab on Jan 4, 2020
- PastaPastaPasta referenced this in commit 69f55882be on Jan 12, 2020
- PastaPastaPasta referenced this in commit 1b8db83fb1 on Jan 12, 2020
- PastaPastaPasta referenced this in commit d4fc92f928 on Jan 12, 2020
- PastaPastaPasta referenced this in commit 99269e0bf0 on Jan 12, 2020
- PastaPastaPasta referenced this in commit dff0bd8355 on Jan 12, 2020
- PastaPastaPasta referenced this in commit a2aed2d647 on Jan 12, 2020
- PastaPastaPasta referenced this in commit ce381d0826 on Jan 16, 2020
- ckti referenced this in commit a8463aa343 on Mar 28, 2021
- DrahtBot locked this on Sep 8, 2021
