Simplify logic in CCryptoKeyStore::AddKeyPubKey(...).
wallet: Simplify logic in CCryptoKeyStore::AddKeyPubKey(...) #11682
pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:CCryptoKeyStore-AddKeyPubKey changing 1 files +1 −4-
practicalswift commented at 9:11 AM on November 14, 2017: contributor
-
wallet: Simplify logic in CCryptoKeyStore::AddKeyPubKey(...) d4761db2dd
-
eklitzke commented at 9:14 AM on November 14, 2017: contributor
drive by review but, lgtm
-
promag commented at 9:58 AM on November 14, 2017: member
ACK d4761db.
- fanquake added the label Wallet on Nov 14, 2017
-
MarcoFalke commented at 4:07 PM on November 14, 2017: member
This pattern is used throughout the code base. Fixing a single instance does not really help. Also, not everyone might agree that this "simplifies the logic".
Closing the refactoring pull according to the developer notes.
- MarcoFalke closed this on Nov 14, 2017
-
ryanofsky commented at 4:11 PM on November 14, 2017: member
ACK d4761db2dd77f5924e6b83b6206164892f98465b
- practicalswift deleted the branch on Apr 10, 2021
- DrahtBot locked this on Aug 16, 2022
Contributors
Labels