tests: Remove unused mininode functions {ser,deser}_int_vector(...). Remove unused imports. #11683

pull practicalswift wants to merge 2 commits into bitcoin:master from practicalswift:remove-int-vector-serialization changing 3 files +1 −17

practicalswift commented at 9:19 AM on November 14, 2017: contributor
- Remove unused mininode functions deser_int_vector(f) and ser_int_vector(l). Last use removed in 3858aabbd084b2cc4534c40a178bbcc22fb82968. Friendly ping @jnewbery :-)
- Remove unused imports.
practicalswift renamed this:
~~tests: Remove unused mininode functions deser_int_vector(f) and ser_int_vector(l)~~
tests: Remove unused mininode functions {ser,deser}_int_vector(...). Remove unused imports.
on Nov 14, 2017
fanquake added the label Tests on Nov 14, 2017
promag commented at 2:17 PM on November 14, 2017: member

utACK 5122755.
jnewbery commented at 6:27 PM on November 14, 2017: member

Thanks @practicalswift . Looks good but conflicts with #11648. Do you mind reviewing that first to avoid a rebase?
practicalswift commented at 9:27 PM on November 14, 2017: contributor

@jnewbery Sure!

Should I cherry-pick f9cd9b1bfaf65b4e24c1eb9ca8268513e78cc458 into this PR, or should I await merge of #11648?
jnewbery commented at 9:31 PM on November 14, 2017: member

Thanks! I don't think you need to do anything for now. If #11648 can get merged soon, then I'd just wait for that and rebase this on top. If #11648 takes a while, then it's fine for this to be merged and I'll rebase #11648 on top of this.
practicalswift commented at 9:33 PM on November 14, 2017: contributor

@jnewbery Great! 👍
Remove unused imports 0f3b752ec7
tests: Remove unused mininode functions deser_int_vector(f) and ser_int_vector(l) f522fb7c9c
practicalswift force-pushed on Nov 17, 2017
practicalswift commented at 2:36 PM on November 17, 2017: contributor

Rebased! :-)
jnewbery commented at 4:39 PM on November 17, 2017: member

Tested ACK f522fb7c9c121641ce552774e3993942106ec336

in test/functional/minchainwork.py:21 in f522fb7c9c

  17 | @@ -18,7 +18,7 @@
  18 |  import time
  19 |  
  20 |  from test_framework.test_framework import BitcoinTestFramework
  21 | -from test_framework.util import sync_blocks, connect_nodes, assert_equal
  22 | +from test_framework.util import connect_nodes, assert_equal

promag commented at 5:30 PM on November 17, 2017:

Do we sort here?

promag commented at 5:30 PM on November 17, 2017: member

Tested ACK.
MarcoFalke commented at 9:53 PM on November 17, 2017: member

utACK f522fb7
fanquake commented at 2:50 AM on November 26, 2017: member

utACK f522fb7
MarcoFalke merged this on Nov 26, 2017
MarcoFalke closed this on Nov 26, 2017
MarcoFalke referenced this in commit a89221873a on Nov 26, 2017
PastaPastaPasta referenced this in commit a8f7f72eca on Apr 4, 2020
PastaPastaPasta referenced this in commit a4bdc16b10 on Apr 5, 2020
ckti referenced this in commit dbcd4f23d5 on Mar 28, 2021
practicalswift deleted the branch on Apr 10, 2021
gades referenced this in commit 9eeea5ef61 on Feb 21, 2022
DrahtBot locked this on Aug 16, 2022

Contributors

Labels