Windows build doc update #11704

pull sipsorcery wants to merge 1 commits into bitcoin:master from sipsorcery:windoc changing 1 files +49 −23

sipsorcery commented at 12:57 PM on November 16, 2017: member

Attempted to make introduction clearer. Added note about required location of source code.

The note about the source code location should stop the issues being logged about the automake errors when building the dependencies.
laanwj commented at 2:10 PM on November 16, 2017: member

LGTM, utACK https://github.com/bitcoin/bitcoin/pull/11704/commits/7605da94501e40592d626f36f42dd896597fff9b
laanwj added the label Docs and Output on Nov 16, 2017

in doc/build-windows.md:101 in 7605da9450 outdated

  97 | @@ -94,6 +98,18 @@ Ubuntu Zesty 17.04 <sup>[2](#footnote2)</sup>:
  98 |  
  99 |  Once the tool chain is installed the build steps are common:
 100 |  
 101 | +Note that for WSL the Bitcoin Core source path MUST be somewhere in the default mount file system, for

Thoragh commented at 4:47 PM on November 16, 2017:

This should also be written under building for 32-bit windows.

sipsorcery commented at 12:15 AM on November 17, 2017:

Done.

fanquake added the label Windows on Nov 16, 2017
sipsorcery force-pushed on Nov 17, 2017
fanquake commented at 1:18 AM on November 17, 2017: member

Please update the commit message to something more meaningful. Include [Doc] and mention Windows etc.
sipsorcery force-pushed on Nov 17, 2017

in doc/build-windows.md:8 in 007fe9714e outdated

  12 | -It is possible to build on Ubuntu Xenial by installing the cross compiler packages from
  13 | -Ubuntu Zesty, see the steps below.
  14 | -Building on Ubuntu Zesty 17.04 up to 17.10 has been verified to work.
  15 | +The options known to work for building Bitcoin Core on Windows are:
  16 | +
  17 | +* On Linux using the (Mingw-w64)[https://mingw-w64.org/doku.php] cross compiler tool chain. Ubuntu Trusty 14.04 is recommended

fanquake commented at 1:05 PM on November 17, 2017:

Need to swap parens and square brackets on this link

Added steps to specify required source location for Windows WSL builds. Attempted to make the introduction and options for building on Windows clearer. 77d51c7498

in doc/build-windows.md:16 in 007fe9714e outdated

  24 | -While there are potentially a number of ways to build on Windows (for example using msys / mingw-w64),
  25 | -using the Windows Subsystem For Linux is the most straightforward. If you are building with
  26 | -another method, please contribute the instructions here for others who are running versions
  27 | -of Windows that are not compatible with the Windows Subsystem for Linux.
  28 | +* On Windows using a POSIX compatibility layer application such as [cygwin](http://www.cygwin.com/) or [msys2](http://www.msys2.org/).
  29 | +* On Windows using a native compiler tool chain such as (Visual Studio)[https://www.visualstudio.com].

fanquake commented at 1:07 PM on November 17, 2017:

same here

sipsorcery force-pushed on Nov 17, 2017
laanwj commented at 1:32 PM on November 17, 2017: member

Thanks, merged via ea68190
laanwj closed this on Nov 17, 2017
laanwj referenced this in commit ea68190132 on Nov 17, 2017
sipsorcery deleted the branch on Nov 21, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels