[docs] links to code style guides #11729

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:docs-style-guide-links changing 1 files +1 −1

Sjors commented at 3:13 PM on November 19, 2017: member

I always have difficulty finding these, probably because they're not actually called "code style guideline".
fanquake added the label Docs and Output on Nov 19, 2017

in CONTRIBUTING.md:189 in 356a025d17 outdated

 185 | @@ -186,7 +186,7 @@ In general, all pull requests must:
 186 |      the project (for example refactoring for modularisation);
 187 |    - Be well peer reviewed;
 188 |    - Have unit tests and functional tests where appropriate;
 189 | -  - Follow code style guidelines;
 190 | +  - Follow code style guidelines ([C++](doc/developer-notes.md), [function tests](test/functional/README.md));

meshcollider commented at 11:33 PM on November 19, 2017:

Nit: functional tests not function tests

Sjors commented at 12:47 PM on November 20, 2017:

Fixed typo.

meshcollider commented at 11:34 PM on November 19, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/pull/11729/commits/356a025d17a6ef3daad66ebc31494e4c8e15e49f
[docs] links to code style guides fe27a72362
Sjors force-pushed on Nov 20, 2017
practicalswift commented at 1:04 PM on November 20, 2017: contributor

ACK fe27a72362ea8a165fd4648ee322541254d71228

Failed Travis job restarted!
fanquake commented at 1:36 PM on November 20, 2017: member

ACK fe27a72
promag commented at 3:32 PM on November 20, 2017: member

ACK fe27a72.
MarcoFalke merged this on Nov 20, 2017
MarcoFalke closed this on Nov 20, 2017
MarcoFalke referenced this in commit 7a43fbb959 on Nov 20, 2017
PastaPastaPasta referenced this in commit d542233c2a on Feb 13, 2020
PastaPastaPasta referenced this in commit 936635b9da on Feb 27, 2020
PastaPastaPasta referenced this in commit 3d6713d651 on Feb 27, 2020
ckti referenced this in commit 1847f15cd7 on Mar 28, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels