[tests] Rename NodeConn and NodeConnCB #11791

1. 
   jnewbery commented at 10:16 pm on November 29, 2017: member

   Final step in #11518

   NodeConn -> P2PConnection NodeConnCB -> P2PInterface

   This is basically just a rename. Should be an easy review.

2. [tests] Rename NodeConn and NodeConnCB

   NodeConn -> P2PConnection
   NodeConnCB -> P2PInterface

   873beca6de
3. fanquake added the label Tests on Nov 29, 2017
4. 
   fanquake commented at 1:24 am on November 30, 2017: member

   After merging the only mention of NodeConn or NodeConnCB I could find was in the 0.15 release notes.

   Compiled and ran the testsuite.

   ACK 873beca

5. 
   practicalswift commented at 7:14 am on November 30, 2017: contributor

   utACK 873beca6deda119077f53921f0d19c3ebfc7cc44
6. in test/functional/example_test.py:25 in 873beca6de

   17@@ -18,10 +18,11 @@
   18 from test_framework.mininode import (
   19     CInv,
   20     NetworkThread,
   21-    NodeConnCB,
   22+    P2PInterface,
   23     mininode_lock,
   24     msg_block,
   25     msg_getdata,
   26+    NODE_NETWORK,
   

   ---

   ---

   

   MarcoFalke commented at 10:52 pm on November 30, 2017:

   style-nit: Unused import
7. 
   MarcoFalke commented at 11:03 pm on November 30, 2017: member

   utACK 873beca6deda119077f53921f0d19c3ebfc7cc44
8. MarcoFalke merged this on Nov 30, 2017
9. MarcoFalke closed this on Nov 30, 2017

   ---

10. MarcoFalke referenced this in commit 13e31dd654 on Nov 30, 2017
11. jnewbery deleted the branch on Nov 30, 2017
12. PastaPastaPasta referenced this in commit 745a7afabd on Apr 6, 2020
13. PastaPastaPasta referenced this in commit 1ab6447f10 on Apr 8, 2020
14. ckti referenced this in commit 817fd8a827 on Mar 28, 2021
15. gades referenced this in commit c616178060 on Jun 30, 2021
16. DrahtBot locked this on Sep 8, 2021

Contributors
jnewbery fanquake practicalswift MarcoFalke

Labels
Tests