[tests] Rename NodeConn and NodeConnCB #11791

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:rename_node_conn changing 18 files +50 −55

jnewbery commented at 10:16 PM on November 29, 2017: member

Final step in #11518

NodeConn -> P2PConnection NodeConnCB -> P2PInterface

This is basically just a rename. Should be an easy review.

[tests] Rename NodeConn and NodeConnCB

NodeConn -> P2PConnection
NodeConnCB -> P2PInterface

873beca6de

fanquake added the label Tests on Nov 29, 2017
fanquake commented at 1:24 AM on November 30, 2017: member

After merging the only mention of NodeConn or NodeConnCB I could find was in the 0.15 release notes.

Compiled and ran the testsuite.

ACK 873beca
practicalswift commented at 7:14 AM on November 30, 2017: contributor

utACK 873beca6deda119077f53921f0d19c3ebfc7cc44

in test/functional/example_test.py:25 in 873beca6de

  17 | @@ -18,10 +18,11 @@
  18 |  from test_framework.mininode import (
  19 |      CInv,
  20 |      NetworkThread,
  21 | -    NodeConnCB,
  22 | +    P2PInterface,
  23 |      mininode_lock,
  24 |      msg_block,
  25 |      msg_getdata,
  26 | +    NODE_NETWORK,

MarcoFalke commented at 10:52 PM on November 30, 2017:

style-nit: Unused import

MarcoFalke commented at 11:03 PM on November 30, 2017: member

utACK 873beca6deda119077f53921f0d19c3ebfc7cc44
MarcoFalke merged this on Nov 30, 2017
MarcoFalke closed this on Nov 30, 2017
MarcoFalke referenced this in commit 13e31dd654 on Nov 30, 2017
jnewbery deleted the branch on Nov 30, 2017
PastaPastaPasta referenced this in commit 745a7afabd on Apr 6, 2020
PastaPastaPasta referenced this in commit 1ab6447f10 on Apr 8, 2020
ckti referenced this in commit 817fd8a827 on Mar 28, 2021
gades referenced this in commit c616178060 on Jun 30, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#11518 [tests] [demonstration] Simplify/clarify the NodeConn/NodeConnCB mininode classes