I accidentally [deliberately] killed it [the ComparisonTestFramework] #11818

pull jnewbery wants to merge 2 commits into bitcoin:master from jnewbery:remove_comp_framework changing 6 files +0 −922

jnewbery commented at 4:30 PM on December 2, 2017: member
Builds on #11772, #11773 and #11817. Please review those PRs first.

Final step in #10603.
- First commit removes bip9-softforks.py. bip9-sofforks.py was intended to be a generic test for versionbits deployments. However, it only tests CSV activation and was not updated to test segwit activation. CSV activation is tested by bip68-112-113-p2p.py, so this test is duplicated effort. Rather than try to update it to use the BitcoinTestFramework, just remove it. (see https://github.com/btcdrak/bitcoin/pull/8 for previous discussion around the redundancy of bip9-softforks.py)
- Second commit removes the now unused BitcoinComparisonFramework class and the comptool and blockstore modules.
jnewbery cross-referenced this on Dec 2, 2017 from issue Retire the comparison test framework by jnewbery
fanquake added the label Tests on Dec 2, 2017
jnewbery force-pushed on Dec 14, 2017
ryanofsky commented at 9:27 PM on December 20, 2017: contributor
Reviewed just the two removal commits, assuming all the other commits will go away when this is rebased.
- utACK 5e483e1eae34083ebfe7bc89d21644fa2c8f4389 [tests] Remove Comparison Test Framework
- utACK 8be729761f794d92b5bec2262ebee9fea35e518a [tests] Remove bip9-softforks.py
laanwj assigned MarcoFalke on Mar 6, 2018
jnewbery force-pushed on Mar 29, 2018
jnewbery commented at 3:50 PM on March 29, 2018: member

Rebased to remove merged commits.
jnewbery cross-referenced this on Apr 2, 2018 from issue Tests: Add Metaclass for BitcoinTestFramework by WillAyd

[tests] Remove bip9-softforks.py

bip9-sofforks.py was intended to be a generic test for versionbits
deployments. However, it only tests CSV activation and was not updated
to test segwit activation. CSV activation is tested by
bip68-112-113-p2p.py, so this test is duplicated effort.

Rather than try to update it to use the BitcoinTestFramework, just
remove it.

e80c640d78

jnewbery force-pushed on Apr 2, 2018
jnewbery commented at 5:47 PM on April 2, 2018: member

Rebased. This should be a very easy review, since it's just removing dead code.
sdaftuar commented at 5:53 PM on April 2, 2018: member

utACK! Thanks for sticking with this.
[tests] Remove Comparison Test Framework 9c92c8c827
in test/functional/README.md:138 in 2382bca42b outdated
```
 133 | -    acceptance is tested against the given outcome.
 134 | -
 135 | -- For examples of tests written in this framework, see
 136 | -  `p2p_invalid_block.py` and `feature_block.py`.
 137 | -
 138 | -### test-framework modules
```
MarcoFalke commented at 5:55 PM on April 2, 2018:

nit: Is this line supposed to go away?

jnewbery commented at 6:04 PM on April 2, 2018:

Good spot! Added that back, and removed the documentation for test_framework/blockstore.py
jnewbery force-pushed on Apr 2, 2018
MarcoFalke commented at 6:34 PM on April 2, 2018: member

utACK 9c92c8c82716d0c35b638142a1125d07b3f240a8
MarcoFalke merged this on Apr 5, 2018
MarcoFalke closed this on Apr 5, 2018
MarcoFalke referenced this in commit 9a2db3b3d5 on Apr 5, 2018
jnewbery deleted the branch on Apr 5, 2018
scravy cross-referenced this on Apr 2, 2019 from issue Do we want to keep Bip9-style deployments? by scravy
codablock cross-referenced this on Jan 5, 2020 from issue Backport bitcoin#11773: [tests] Change feature_block.py to use BitcoinTestFramework by codablock
codablock cross-referenced this on Jan 5, 2020 from issue Backport bitcoin#11818: I accidentally [deliberately] killed it [the ComparisonTestFramework] by codablock
codablock referenced this in commit c88a7b9e76 on Jan 14, 2020
random-zebra cross-referenced this on May 4, 2021 from issue [Tests] Resurrect feature_block and kill the p2p comparison test framework by random-zebra
random-zebra referenced this in commit db5e692613 on May 17, 2021
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10603 Retire the comparison test framework #11771 [tests] Change invalidtxrequest to use BitcoinTestFramework #11772 [tests] Change invalidblockrequest to use BitcoinTestFramework #11773 [tests] Change feature_block.py to use BitcoinTestFramework #11817 [tests] Change feature_csv_activation.py to use BitcoinTestFramework #12856 Tests: Add Metaclass for BitcoinTestFramework