Rename rpcuser.py to rpcauth.py

hkjn commented at 1:12 pm on December 6, 2017: contributor

This script creates rpcauth entries for bitcoin.conf, not the deprecated rpcuser entry, so this changes the name of the script to match.

As discussed in #11830.

This script creates `rpcauth` entries for bitcoin.conf,
not the deprecated `rpcuser` entry, so this changes the name
of the script to match.

3fdb29778a

hkjn commented at 6:21 pm on December 6, 2017: contributor

The test that failed on Travis produced the following stacktrace:

 0Traceback (most recent call last):
 1  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/segwit.py", line 673, in <module>
 2    SegWitTest().main()
 3  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 142, in main
 4    self.stop_nodes()
 5  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 263, in stop_nodes
 6    node.wait_until_stopped()
 7  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_node.py", line 150, in wait_until_stopped
 8    wait_until(self.is_node_stopped, timeout=timeout)
 9  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 215, in wait_until
10    if predicate():
11  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_node.py", line 141, in is_node_stopped
12    assert_equal(return_code, 0)
13  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 38, in assert_equal
14    raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
15AssertionError: not(1 == 0)

I could be missing something, but it doesn’t seem to indicate the line number of the failed assertion; just that the failure was in segwit.py’s SegWitTest.main(), making it hard to dig into the cause of the failure..

(The failure message that 1 is not equal to 0 is also not very illuminating..)

Running what via Travis logs looks like the relevant test command locally produces no failures for segwit.py:

 0$ test/functional/test_runner.py --combinedlogslen=4000 --coverage --quiet --extended --exclude pruning,dbcrash
 1[ ... ]
 2TEST                           | STATUS    | DURATION
 3
 4abandonconflict.py             | P Passed  | 19 s
 5assumevalid.py                 | P Passed  | 132 s
 6bip65-cltv-p2p.py              | P Passed  | 46 s
 7bip68-112-113-p2p.py           | P Passed  | 95 s
 8bip68-sequence.py              | P Passed  | 228 s
 9bip9-softforks.py              | P Passed  | 1621 s
10bipdersig-p2p.py               | P Passed  | 38 s
11bitcoin_cli.py                 | P Passed  | 5 s
12blockchain.py                  | P Passed  | 17 s
13bumpfee.py                     | P Passed  | 34 s
14decodescript.py                | P Passed  | 5 s
15deprecated_rpc.py              | P Passed  | 5 s
16disablewallet.py               | P Passed  | 4 s
17disconnect_ban.py              | P Passed  | 11 s
18example_test.py                | P Passed  | 7 s
19feature_logging.py             | x Failed  | 7 s
20fundrawtransaction.py          | P Passed  | 68 s
21getblocktemplate_longpoll.py   | P Passed  | 73 s
22getchaintips.py                | P Passed  | 13 s
23httpbasics.py                  | P Passed  | 8 s
24import-rescan.py               | x Failed  | 13 s
25importmulti.py                 | P Passed  | 22 s
26importprunedfunds.py           | P Passed  | 10 s
27invalidateblock.py             | P Passed  | 12 s
28invalidblockrequest.py         | P Passed  | 12 s
29invalidtxrequest.py            | P Passed  | 12 s
30keypool-topup.py               | P Passed  | 45 s
31keypool.py                     | P Passed  | 23 s
32listsinceblock.py              | x Failed  | 6 s
33listtransactions.py            | P Passed  | 33 s
34maxuploadtarget.py             | P Passed  | 947 s
35mempool_limit.py               | P Passed  | 30 s
36mempool_packages.py            | P Passed  | 68 s
37mempool_persist.py             | x Failed  | 20 s
38mempool_reorg.py               | P Passed  | 11 s
39mempool_resurrect_test.py      | P Passed  | 6 s
40mempool_spendcoinbase.py       | P Passed  | 5 s
41merkle_blocks.py               | P Passed  | 15 s
42minchainwork.py                | x Failed  | 5 s
43mining.py                      | x Failed  | 8 s
44multi_rpc.py                   | P Passed  | 9 s
45multiwallet.py                 | P Passed  | 17 s 
46net.py                         | P Passed  | 6 s
47notifications.py               | P Passed  | 10 s  
48nulldummy.py                   | P Passed  | 18 s  
49p2p-acceptblock.py             | P Passed  | 28 s
50p2p-compactblocks.py           | P Passed  | 129 s 
51p2p-feefilter.py               | P Passed  | 66 s  
52p2p-fingerprint.py             | P Passed  | 13 s
53p2p-fullblocktest.py           | x Failed  | 1962 s
54p2p-leaktests.py               | P Passed  | 12 s 
55p2p-mempool.py                 | P Passed  | 4 s
56p2p-segwit.py                  | P Passed  | 984 s 
57p2p-timeouts.py                | P Passed  | 66 s  
58p2p-versionbits-warning.py     | P Passed  | 20 s  
59preciousblock.py               | P Passed  | 11 s  
60prioritise_transaction.py      | P Passed  | 40 s  
61proxy_test.py                  | P Passed  | 11 s  
62rawtransactions.py             | P Passed  | 30 s  
63receivedby.py                  | P Passed  | 13 s  
64reindex.py                     | P Passed  | 19 s  
65replace-by-fee.py              | P Passed  | 41 s 
66resendwallettransactions.py    | P Passed  | 7 s
67rest.py                        | P Passed  | 14 s  
68rpcbind_test.py                | P Passed  | 15 s 
69rpcnamedargs.py                | P Passed  | 5 s
70segwit.py                      | P Passed  | 99 s  
71sendheaders.py                 | P Passed  | 30 s 
72signmessages.py                | P Passed  | 4 s  
73signrawtransactions.py         | P Passed  | 4 s
74smartfees.py                   | P Passed  | 487 s 
75txn_clone.py                   | P Passed  | 13 s  
76txn_clone.py --mineblock       | P Passed  | 14 s  
77txn_doublespend.py             | P Passed  | 13 s  
78txn_doublespend.py --mineblock | P Passed  | 13 s 
79uacomment.py                   | x Failed  | 9 s  
80uptime.py                      | P Passed  | 4 s
81wallet-accounts.py             | P Passed  | 32 s  
82wallet-dump.py                 | P Passed  | 30 s  
83wallet-encryption.py           | P Passed  | 26 s
84wallet-hd.py                   | P Passed  | 267 s 
85wallet.py                      | P Passed  | 87 s
86walletbackup.py                | P Passed  | 184 s 
87zapwallettxes.py               | P Passed  | 12 s 
88zmq_test.py                    | o Skipped | 5 s
89
90ALL                            | x Failed  | 8622 s (accumulated)

However several other tests do fail locally.. this leads me to believe that issues seen in Travis as well as locally are issues with the test or test framework rather than the proposed change in this PR. I’d be happy to try to track down those test issues (possibly nondeterministic, since behavior differs locally and on CI), but I’m still getting acquinted with the test framework, so it might take some time.

ryanofsky commented at 6:40 pm on December 6, 2017: member

I restarted your travis test. Segwit.py failure is probably due to the return code bug fixed in #11831

ryanofsky commented at 6:42 pm on December 6, 2017: member

utACK 3fdb29778a0b598d4ddf05ec5ed4593641d0da6e. Might be worth a mention in doc/release-notes.md too

doc: Update release notes for share/rpcauth/rpcauth.py rename 3121d76ba1

hkjn commented at 6:54 pm on December 6, 2017: contributor

Thanks @ryanofsky. For future reference, is there a way I can restart the test on Travis myself? (Short of pushing a change, I mean.)

I’ve taken a stab at updating doc/release-notes.md as well in this PR. Let me know how that looks.

ryanofsky commented at 7:03 pm on December 6, 2017: member

I think if you’re a github project member you can restart travis jobs.

ryanofsky commented at 7:06 pm on December 6, 2017: member

utACK 3121d76ba11043ea5c4e957ac0c3edbf21d1e84d. Updated release notes look good to me.

hkjn commented at 7:07 pm on December 6, 2017: contributor

Ah, you mean if you authorize travis-ci.org to access your Github repos / orgs some button shows up on the build results page? I’ve been avoiding that due to the wide-ranging permissions they ask for, but maybe there’s a need to be pragmatic..

ryanofsky commented at 7:19 pm on December 6, 2017: member

Ah, you mean if you authorize travis-ci.org to access your Github repos / orgs some button shows up on the build results page? I’ve been avoiding that due to the wide-ranging permissions they ask for, but maybe there’s a need to be pragmatic..

If you become a member of the bitcoin/bitcoin github project, a “restart job” button shows up letting you restart travis runs associated with bitcoin/bitcoin PR’s. Someone administering the project has to add you. You could ask about it on IRC.

Authorizing travis-ci.org to your github project would just let travis interact with your forked bitcoin repo, not have any effect on the main one.

fanquake added the label Scripts and tools on Dec 6, 2017

sipa commented at 11:20 pm on December 6, 2017: member

Concept ACK

hkjn commented at 5:20 pm on December 7, 2017: contributor

Thanks for explaining Travis stuff, @ryanofsky, makes sense. I’m not going to bother poking anyone around joining the bitcoin project on GH at this time, I think, but will wait until I’ve made some more sizeable contributions.

Since tests passed on CI I think this can be merged at any time you want. (I’m still trying to debug the test failures I mentioned above, some of which seem persistent, but those tests fail on clean master as well locally, so clearly something different in my environment.)

hkjn commented at 3:26 pm on December 11, 2017: contributor

cc @TheBlueMatt @achow101, this PR is the follow-up we discussed in #11830, in case you would like to review and/or merge.

achow101 commented at 4:13 pm on December 11, 2017: member

utACK 3121d76ba11043ea5c4e957ac0c3edbf21d1e84d

laanwj merged this on Dec 11, 2017

laanwj closed this on Dec 11, 2017

laanwj referenced this in commit d44535d818 on Dec 11, 2017

hkjn deleted the branch on Feb 20, 2018

PastaPastaPasta referenced this in commit cce805d69a on Feb 13, 2020

PastaPastaPasta referenced this in commit 975e69eb25 on Feb 27, 2020

PastaPastaPasta referenced this in commit 07316dda2c on Feb 27, 2020

PastaPastaPasta referenced this in commit edfb8fcb6d on Mar 14, 2020

PastaPastaPasta referenced this in commit d9c913479a on Mar 19, 2020

PastaPastaPasta referenced this in commit 53fd996aaf on Mar 28, 2020

ckti referenced this in commit 11fd85ff6d on Mar 28, 2021

gades referenced this in commit 48881c3548 on Jun 28, 2021

DrahtBot locked this on Sep 8, 2021

Rename rpcuser.py to rpcauth.py #11836