Split up key and script metadata for better type safety #11854

1. 
   ryanofsky commented at 5:56 pm on December 8, 2017: member

   Suggested by @TheBlueMatt #11403 (review)

   Combining the maps was probably never a good arrangement but is more problematic now in presence of WitnessV0ScriptHash and WitnessV0KeyHash types.

2. Split up key and script metadata for better type safety

   Suggested by Matt Corallo <git@bluematt.me>
   https://github.com/bitcoin/bitcoin/pull/11403#discussion_r155599383
   
   Combining the maps was probably never a good arrangement but is more
   problematic now in presence of WitnessV0ScriptHash and WitnessV0KeyHash types.

   9c8eca7704
3. 
   TheBlueMatt commented at 6:33 pm on December 8, 2017: member

   utACK 9c8eca7704e88b3f4ee38cf85bef0f1febc440e5
4. 
   sipa commented at 11:24 pm on December 8, 2017: member

   utACK 9c8eca7704e88b3f4ee38cf85bef0f1febc440e5

   Looks like an obvious cleanup for the current state of things. Over time, I think this metadata should be associated with scriptPubKeys or chains thereof rather than with keys, but that’s much more invasive.

5. fanquake added the label Wallet on Dec 11, 2017
6. 
   theuni commented at 6:38 pm on December 12, 2017: member

   utACK 9c8eca7704e88b3f4ee38cf85bef0f1febc440e5
7. 
   jonasschnelli commented at 6:51 pm on December 12, 2017: contributor

   utACK 9c8eca7704e88b3f4ee38cf85bef0f1febc440e5
8. laanwj merged this on Dec 12, 2017
9. laanwj closed this on Dec 12, 2017

   ---

10. laanwj referenced this in commit 22149540f9 on Dec 12, 2017
11. PastaPastaPasta referenced this in commit 3810f0123c on Mar 23, 2020
12. PastaPastaPasta referenced this in commit 318232503e on Mar 28, 2020
13. PastaPastaPasta referenced this in commit cc041952b7 on Mar 29, 2020
14. PastaPastaPasta referenced this in commit 2f72fcc35a on Mar 31, 2020
15. UdjinM6 referenced this in commit e09077af41 on Mar 31, 2020
16. PastaPastaPasta referenced this in commit 9d3c7c3ca6 on Apr 1, 2020
17. ckti referenced this in commit 2f08e2d954 on Mar 28, 2021
18. DrahtBot locked this on Sep 8, 2021

Contributors
ryanofsky TheBlueMatt sipa theuni jonasschnelli

Labels
Wallet