Suggested by @TheBlueMatt #11403 (review)
Combining the maps was probably never a good arrangement but is more problematic now in presence of WitnessV0ScriptHash and WitnessV0KeyHash types.
Split up key and script metadata for better type safety #11854
pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/scriptmet changing 4 files +48 −34-
ryanofsky commented at 5:56 PM on December 8, 2017: member
-
9c8eca7704
Split up key and script metadata for better type safety
Suggested by Matt Corallo <git@bluematt.me> https://github.com/bitcoin/bitcoin/pull/11403#discussion_r155599383 Combining the maps was probably never a good arrangement but is more problematic now in presence of WitnessV0ScriptHash and WitnessV0KeyHash types.
-
TheBlueMatt commented at 6:33 PM on December 8, 2017: member
utACK 9c8eca7704e88b3f4ee38cf85bef0f1febc440e5
-
sipa commented at 11:24 PM on December 8, 2017: member
utACK 9c8eca7704e88b3f4ee38cf85bef0f1febc440e5
Looks like an obvious cleanup for the current state of things. Over time, I think this metadata should be associated with scriptPubKeys or chains thereof rather than with keys, but that's much more invasive.
- fanquake added the label Wallet on Dec 11, 2017
-
theuni commented at 6:38 PM on December 12, 2017: member
utACK 9c8eca7704e88b3f4ee38cf85bef0f1febc440e5
-
jonasschnelli commented at 6:51 PM on December 12, 2017: contributor
utACK 9c8eca7704e88b3f4ee38cf85bef0f1febc440e5
- laanwj merged this on Dec 12, 2017
- laanwj closed this on Dec 12, 2017
- laanwj referenced this in commit 22149540f9 on Dec 12, 2017
- PastaPastaPasta referenced this in commit 3810f0123c on Mar 23, 2020
- PastaPastaPasta referenced this in commit 318232503e on Mar 28, 2020
- PastaPastaPasta referenced this in commit cc041952b7 on Mar 29, 2020
- PastaPastaPasta referenced this in commit 2f72fcc35a on Mar 31, 2020
- UdjinM6 referenced this in commit e09077af41 on Mar 31, 2020
- PastaPastaPasta referenced this in commit 9d3c7c3ca6 on Apr 1, 2020
- ckti referenced this in commit 2f08e2d954 on Mar 28, 2021
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels