Wallet : remove unused fNoncriticalErrors variable from CWalletDB::FindWalletTx #11923

1. 
   PierreRochard commented at 4:22 pm on December 17, 2017: contributor

   The CWalletDB::FindWalletTx method was patterned after CWalletDB::LoadWallet, where fNoncriticalErrors is used when a tx check fails in ReadKeyValue.

   Since FindWalletTx is only used by methods which are zapping txs, it makes sense that ReadKeyValue is not called and the tx is not checked, so I think that deleting the unused fNoncriticalErrors boolean variable and its conditional statement is appropriate.

2. remove unused fNoncriticalErrors variable from CWalletDB::FindWalletTx ecf9b25a03
3. fanquake added the label Wallet on Dec 17, 2017
4. 
   promag commented at 2:41 am on December 18, 2017: member

   ACK ecf9b25.
5. dcousens approved
6. 
   ryanofsky commented at 3:57 pm on December 18, 2017: member

   utACK ecf9b25a03d8a29f16005ca4485b6533db6efc82
7. 
   practicalswift commented at 4:23 am on December 19, 2017: contributor

   Nice find!

   utACK ecf9b25a03d8a29f16005ca4485b6533db6efc82

8. 
   laanwj commented at 3:16 pm on December 19, 2017: member

   utACK ecf9b25
9. laanwj merged this on Dec 19, 2017
10. laanwj closed this on Dec 19, 2017

    ---

11. laanwj referenced this in commit 81c89e966e on Dec 19, 2017
12. PierreRochard deleted the branch on Dec 19, 2017
13. PastaPastaPasta referenced this in commit d839e3b040 on Feb 13, 2020
14. PastaPastaPasta referenced this in commit 2872a42979 on Feb 27, 2020
15. PastaPastaPasta referenced this in commit e1f6eee283 on Feb 27, 2020
16. PastaPastaPasta referenced this in commit b446236e25 on Feb 27, 2020
17. ckti referenced this in commit 9fc572d4ab on Mar 28, 2021
18. MarcoFalke locked this on Sep 8, 2021

Contributors
PierreRochard promag dcousens ryanofsky practicalswift laanwj

Labels
Wallet