Remove unused mempool index #12127

1. 
   sdaftuar commented at 1:21 am on January 9, 2018: member

   We haven’t used the “mining_score” index since 0.12, so remove it.
2. fanquake added the label Mempool on Jan 9, 2018
3. jonasschnelli assigned luke-jr on Jan 9, 2018
4. 
   sipa commented at 9:11 am on January 9, 2018: member

   utACK
5. 
   promag commented at 10:29 am on January 9, 2018: member

   Remove comment: https://github.com/bitcoin/bitcoin/blob/45173fa6fca9537abb0a0554f731d14b9f89c456/src/txmempool.h#L359
6. Remove unused mempool index 8e617e3708
7. sdaftuar force-pushed on Jan 9, 2018
8. 
   sdaftuar commented at 1:59 pm on January 9, 2018: member

   Thanks @promag, fixed.
9. 
   promag commented at 2:14 pm on January 9, 2018: member

   utACK 8e617e3.
10. 
    morcos commented at 2:23 pm on January 9, 2018: member

    concept ACK

    Note: This score was useful for quick approximations for fee estimation and to observe how closely miner policy is matching expectations (as well as possibly coinsviewcache warming). However none of this has made it into master in a couple years and the goals are probably equally accomplishable by using ancestor_score sorting and skipping entries with ancestors.

11. 
    TheBlueMatt commented at 0:42 am on January 10, 2018: member

    Can we kill CTxMemPool::GetSortedDepthAndScore() and DepthAndScoreComparator, too? I dont see why queryHashes (used to flush fee estimator - this should probably loop over mapTx or something to avoid the needless copy, and getrawmempool output) and infoAll (::MEMPOOL responses and mempool disk-dumping) should be sorted.
12. 
    sdaftuar commented at 1:46 pm on January 10, 2018: member

    @TheBlueMatt I didn’t look at the fee estimator usage at all, but we use depth-and-score comparisons for both responding to MEMPOOL requests and for regular transaction relay, to avoid relaying child transactions before parents, which I think is essential behavior. The sort-by-feerate is imo desirable , if not essential. I don’t think we should get rid of either behavior.

    However I think we can get rid of CompareTxMemPoolEntryByScore after #12118, and replace its only remaining uses with the ancestor feerate comparison (that’s the only remaining change I had left at the moment), once that’s fixed to be the min(feerate, feerate_with_ancestors). I was going to PR that separately after these were merged.

    If reviewers would rather see all these changes in one PR, I can do that too (I thought smaller would be better here).

13. 
    ryanofsky commented at 9:57 pm on January 10, 2018: member

    utACK 8e617e3708e0e4d42d586531450a21ae70aecf63. Seems fine to make the other changes separately.
14. 
    TheBlueMatt commented at 5:53 pm on January 11, 2018: member

    utACK 8e617e3708e0e4d42d586531450a21ae70aecf63, though I’d prefer if the sort in queryHashes were killed as its uneccessary for its users, and then remove the local prioritization’s effect on scoring and maybe rename it or give the score sorter more clear documentation for what its (now) used for.
15. 
    laanwj commented at 8:57 am on January 15, 2018: member

    utACK 8e617e3

    Seems fine to make the other changes separately.

    Agree - this is an easy to review, self-contained change, the rest can be done later, no reason to extend the scope.

16. laanwj merged this on Jan 15, 2018
17. laanwj closed this on Jan 15, 2018

    ---

18. laanwj referenced this in commit 9501dc27b3 on Jan 15, 2018
19. laanwj referenced this in commit 67447ba060 on Feb 8, 2018
20. PastaPastaPasta referenced this in commit c614535082 on Jan 17, 2020
21. PastaPastaPasta referenced this in commit d341f91448 on Jan 22, 2020
22. PastaPastaPasta referenced this in commit 0236aea13b on Jan 22, 2020
23. PastaPastaPasta referenced this in commit 520afe2465 on Jan 29, 2020
24. PastaPastaPasta referenced this in commit 61edcd80de on Jan 29, 2020
25. PastaPastaPasta referenced this in commit bcfacb4cc9 on Jan 29, 2020
26. PastaPastaPasta referenced this in commit e158f1ad5b on Jan 31, 2020
27. PastaPastaPasta referenced this in commit 361cd424b7 on Jul 17, 2020
28. PastaPastaPasta referenced this in commit c0a094ebe3 on Jul 17, 2020
29. PastaPastaPasta referenced this in commit ed5f046a99 on Jul 17, 2020
30. ckti referenced this in commit 075703e29a on Mar 28, 2021
31. gades referenced this in commit f9b575e730 on Jun 24, 2021
32. DrahtBot locked this on Sep 8, 2021

Contributors
sdaftuar sipa promag morcos TheBlueMatt ryanofsky laanwj

Labels
Mempool