No description provided.
Remove useless string initializations #12182
pull ghost wants to merge 1 commits into bitcoin:master from changing 5 files +7 −7-
ghost commented at 5:18 PM on January 14, 2018: none
-
bolekC commented at 10:30 PM on January 14, 2018: none
ntACK 4893f5c Not sure but probably compiler will not optimize this so small improvement in performance is possible with this improvement.
- MarcoFalke added the label Refactoring on Jan 14, 2018
-
fanquake commented at 1:28 PM on January 29, 2018: member
Needs a rebase.
-
practicalswift commented at 4:25 PM on February 8, 2018: contributor
Concept ACK, but should ideally be done as a
scripted-diff. Also please squash and add a PR body :-) -
laanwj commented at 10:16 AM on February 12, 2018: member
Needs rebase/squash to get rid of the merge commit. If you're unsure how to do this, see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits .
- laanwj renamed this:
[TRIVIAL] Remove useless string initialization.
Remove useless string initializations
on Feb 12, 2018 - dcousens approved
-
Remove useless string initialization. 19ac86e206
-
ghost commented at 8:03 PM on February 13, 2018: none
rebased
-
practicalswift commented at 8:16 PM on February 13, 2018: contributor
This scripted-diff will fix these:
for F in $(git grep -lE 'std::string [a-zA-Z]*( |)=( |)"";'); do sed -i -E 's/(std::string [a-zA-Z]*)( |)=( |)"";/\1;/g' $F done -
jonasschnelli commented at 7:47 AM on February 17, 2018: contributor
utACK 19ac86e2063432fca1f21fd3ef9770e7bde5d0ff
- laanwj merged this on Mar 1, 2018
- laanwj closed this on Mar 1, 2018
- laanwj referenced this in commit 90a0aed511 on Mar 1, 2018
- markblundeberg referenced this in commit 7cb2951d02 on May 23, 2019
- jonspock referenced this in commit f0f74d2333 on Jun 13, 2019
- jtoomim referenced this in commit d08c6106ac on Jun 29, 2019
- PastaPastaPasta referenced this in commit 80295e1133 on Jun 9, 2020
- PastaPastaPasta referenced this in commit 3ae4f0bc27 on Jun 9, 2020
- PastaPastaPasta referenced this in commit 0131c5cbf9 on Jun 10, 2020
- PastaPastaPasta referenced this in commit fcee540d34 on Jun 10, 2020
- PastaPastaPasta referenced this in commit a362eb807f on Jun 11, 2020
- PastaPastaPasta referenced this in commit 05f3f7ba7c on Jun 11, 2020
- gades referenced this in commit 3d32247eb8 on Jun 25, 2021
- DrahtBot locked this on Sep 8, 2021
Labels