[depends] expat 2.2.5, ccache 3.4.1, miniupnpc 2.0.20180203

fanquake commented at 2:11 am on February 10, 2018: member

miniupnpc changelog: http://miniupnp.free.fr/files/changelog.php?file=miniupnpc-2.0.20180203.tar.gz 2.0.20180203 includes fixes for the recent buffer overflow and segfault issues, see https://github.com/miniupnp/miniupnp/issues/268.

expat changelog: https://github.com/libexpat/libexpat/blob/R_2_2_5/expat/Changes 2.2.2 & 2.2.3 included security fixes.

ccache changelog: https://ccache.samba.org/releasenotes.html#_ccache_3_4_1

Also includes latest config.guess and config.sub.

fanquake added the label Build system on Feb 10, 2018

fanquake requested review from theuni on Feb 10, 2018

fanquake force-pushed on Feb 10, 2018

fanquake commented at 5:14 am on February 10, 2018: member

miniupnpc build error on osx:

 0minissdpc.c:632:35: error: use of undeclared identifier 'IP_MULTICAST_TTL'
 1                if(setsockopt(sudp, IPPROTO_IP, IP_MULTICAST_TTL, &ttl, ...
 2                                                ^
 3minissdpc.c:660:23: error: use of undeclared identifier 'INADDR_NONE'
 4                        if(mc_if.s_addr != INADDR_NONE)
 5                                           ^
 6minissdpc.c:663:37: error: use of undeclared identifier 'IP_MULTICAST_IF'
 7                                if(setsockopt(sudp, IPPROTO_IP, IP_MULTI...
 8                                                                ^
 9minissdpc.c:678:18: error: variable has incomplete type 'struct ifreq'
10                                struct ifreq ifr;
11                                             ^
12minissdpc.c:678:12: note: forward declaration of 'struct ifreq'
13                                struct ifreq ifr;
14                                       ^
15minissdpc.c:680:40: error: use of undeclared identifier 'IFNAMSIZ'
16                                strncpy(ifr.ifr_name, multicastif, IFNAMSIZ);
17                                                                   ^
18/home/travis/build/bitcoin/bitcoin/depends/SDKs/MacOSX10.11.sdk/usr/include/secure/_string.h:119:39: note: 
19      expanded from macro 'strncpy'
20  __builtin___strncpy_chk (dest, src, len, __darwin_obsz (dest))
21                                      ^
22minissdpc.c:681:18: error: use of undeclared identifier 'IFNAMSIZ'
23                                ifr.ifr_name[IFNAMSIZ-1] = '\0';
24                                             ^
25minissdpc.c:682:20: error: invalid application of 'sizeof' to an incomplete type
26      'struct ifreq'
27                                if(ioctl(sudp, SIOCGIFADDR, &ifr, &ifrlen) < 0)
28                                               ^~~~~~~~~~~
29/home/travis/build/bitcoin/bitcoin/depends/SDKs/MacOSX10.11.sdk/usr/include/sys/sockio.h:94:21: note: 
30      expanded from macro 'SIOCGIFADDR'
31#define SIOCGIFADDR     _IOWR('i', 33, struct ifreq)    /* get ifnet address */
32                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
33/home/travis/build/bitcoin/bitcoin/depends/SDKs/MacOSX10.11.sdk/usr/include/sys/ioccom.h:97:48: note: 
34      expanded from macro '_IOWR'
35#define _IOWR(g,n,t)    _IOC(IOC_INOUT, (g), (n), sizeof(t))
36                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
37/home/travis/build/bitcoin/bitcoin/depends/SDKs/MacOSX10.11.sdk/usr/include/sys/ioccom.h:92:13: note: 
38      expanded from macro '_IOC'
39        (inout | ((len & IOCPARM_MASK) << 16) | ((group) << 8) | (num))
40                   ^
41minissdpc.c:678:12: note: forward declaration of 'struct ifreq'
42                                struct ifreq ifr;
43                                       ^
44minissdpc.c:687:37: error: use of undeclared identifier 'IP_MULTICAST_IF'
45                                if(setsockopt(sudp, IPPROTO_IP, IP_MULTI...

fanquake commented at 5:16 am on February 10, 2018: member

Similar (now solved) issue when building on FreeBSD here: https://github.com/miniupnp/miniupnp/issues/151

practicalswift commented at 3:17 pm on February 10, 2018: contributor

Thanks @fanquake for addressing this!

Linking in #12395 for reference.

jonasschnelli commented at 9:31 pm on February 10, 2018: contributor

Gitian depends complication seems to fail (we compile the dependency but don’t use it AFAIK): https://bitcoin.jonasschnelli.ch/build/494

MarcoFalke commented at 9:34 pm on February 10, 2018: member

gitian fails due to #12386

fanquake force-pushed on Feb 13, 2018

fanquake renamed this:
~~[depends] expat 2.2.5, ccache 3.3.6, miniupnpc 2.0.20180203~~
[depends] expat 2.2.5, ccache 3.4.1, miniupnpc 2.0.20180203
on Feb 13, 2018

laanwj commented at 8:49 am on February 15, 2018: member

gitian fails due to #12386

That should be solved, but still travis errors, apparently in the macos build.

0minissdpc.c:632:35: error: use of undeclared identifier 'IP_MULTICAST_TTL'
1                if(setsockopt(sudp, IPPROTO_IP, IP_MULTICAST_TTL, &ttl, ...
2                                                ^

[depends] expat 2.2.5 5a10859a80

[depends] ccache 3.4.1 61647a4b86

[depends] miniupnpc 2.0.20180203 41550d6d13

[depends] latest config.guess and config.sub 3335d45f28

fixme: depends: Add D_DARWIN_C_SOURCE to miniupnpc CFLAGS 25409b16fd

fanquake force-pushed on Feb 15, 2018

fanquake commented at 11:18 am on February 15, 2018: member

Added a commit that should fix the miniupnpc build issues. I might also pull #11995 in here, so it can be reviewed and merged.

laanwj commented at 4:00 pm on February 15, 2018: member

utACK https://github.com/bitcoin/bitcoin/pull/12402/commits/25409b16fd593f45168e839fe21ed0f642908e11

laanwj merged this on Feb 16, 2018

laanwj closed this on Feb 16, 2018

laanwj referenced this in commit 59e032b43c on Feb 16, 2018

theuni commented at 7:02 pm on February 16, 2018: member

The miniupnpc patch here isn’t quite right. The _DARWIN_C_SOURCE needs to be defined for darwin only, not universally as it is now.

fanquake deleted the branch on Feb 17, 2018

achow101 commented at 4:58 am on February 25, 2018: member

It looks like ccache’s bundled zlib is failing to build with mingw which is causing #12515. This was also reported in IRC as causing an issue with a new gitian setup.

fanquake commented at 9:56 am on February 25, 2018: member

This should be addressed in ccache 3.4.2: https://github.com/ccache/ccache/commit/418c419c6bcd6e43eeed2eae5b861441192ebc9e

in doc/dependencies.md:10 in 25409b16fd

 6@@ -7,18 +7,18 @@ These are the dependencies currently used by Bitcoin Core. You can find instruct
 7 | --- | --- | --- | --- | --- | --- |
 8 | Berkeley DB | [4.8.30](http://www.oracle.com/technetwork/database/database-technologies/berkeleydb/downloads/index.html) | 4.8.x | No |  |  |
 9 | Boost | [1.64.0](http://www.boost.org/users/download/) | [1.47.0](https://github.com/bitcoin/bitcoin/pull/8920) | No |  |  |
10-| ccache | [3.3.4](https://ccache.samba.org/download.html) |  | No |  |  |
11+| ccache | [3.3.6](https://ccache.samba.org/download.html) |  | No |  |  |

MarcoFalke commented at 3:24 pm on February 25, 2018:

Should say 3.4.1?

droark commented at 0:40 am on March 3, 2018: contributor

Any chance this can get ported over to the 0.16 branch? I’m trying to do Gitian builds right now. Maybe it’s a coincidence but Sourceforge chokes whenever Gitian attempts to download expat.

fanquake commented at 4:04 am on March 3, 2018: member

@droark See #12585

MarcoFalke referenced this in commit 72a3290c90 on Mar 5, 2018

virtload referenced this in commit 17008a78dd on Apr 4, 2018

deadalnix referenced this in commit 321a3c2e09 on Mar 19, 2020

deadalnix referenced this in commit 4770ec44e8 on Mar 19, 2020

10xcryptodev referenced this in commit 5a40b37a6d on May 16, 2020

10xcryptodev referenced this in commit 0c2b520c48 on May 17, 2020

ftrader referenced this in commit 82462095f1 on May 19, 2020

ftrader referenced this in commit 1490237f97 on May 19, 2020

gades referenced this in commit db78fd187c on Jun 24, 2021

CryptoCentric referenced this in commit 593f97487a on Jul 2, 2021

DrahtBot locked this on Sep 8, 2021

[depends] expat 2.2.5, ccache 3.4.1, miniupnpc 2.0.20180203 #12402