Upgrade mac_alias to 2.0.7 #12417

pull droark wants to merge 2 commits into bitcoin:master from droark:master_del_mac_alias changing 2 files +2 −63
  1. droark commented at 8:36 PM on February 12, 2018: contributor

    The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system.

    Note that this PR won't be complete until a new version of mac_alias containing the patch has been released, and the depends system is updated to reflect the new version.

  2. droark commented at 8:38 PM on February 12, 2018: contributor

    Just for reference, here's the original PR for the mac_alias patch.

  3. MarcoFalke added this to the milestone Future on Feb 12, 2018
  4. fanquake added the label Build system on Feb 12, 2018
  5. thijstriemstra commented at 3:07 PM on February 13, 2018: none

    2.0.7 has been released.

  6. Delete mac_alias patch
    The patch Bitcoin Core has been maintaining for mac_alias was pulled by the mac_alias maintainer in commit 4f31cb084c1c6a8626128b0b00842020b6db9037. Delete the patch and remove the patch from the depends system.

Note that this PR won't be complete until a new version of mac_alias containing the path has been released, and the depends system is updated to reflect the new version.
    deee216bd3
  7. Update mac_alias to 2.0.7 fc1bfcf9fd
  8. droark force-pushed on Feb 14, 2018
  9. droark renamed this:
    [WIP] Delete mac_alias patch
    Delete mac_alias patch
    on Feb 14, 2018
  10. droark commented at 1:23 AM on February 14, 2018: contributor

    Added a commit upgrading mac_alias to 2.0.7 and did make deploy on my Macbook Pro. The resultant DMG file allowed me to place Core in /Applications. Core runs fine. Background image of the DMG looks fine. A couple of the icons are in weird spots but this is apparently normal. Besides, as mentioned, the core functionality is present.

  11. jonasschnelli commented at 10:33 AM on February 14, 2018: contributor

    Tested ACK via Gitian Build: https://bitcoin.jonasschnelli.ch/build/499

  12. laanwj renamed this:
    Delete mac_alias patch
    Upgrade mac_alias to 2.0.7
    on Feb 14, 2018
  13. laanwj commented at 10:57 AM on February 14, 2018: member

    Looks good to me, @theuni might want to sign off on this because it's a depends change.

  14. laanwj assigned theuni on Feb 14, 2018
  15. fanquake commented at 11:00 AM on February 14, 2018: member

    utACK https://github.com/bitcoin/bitcoin/pull/12417/commits/fc1bfcf9fd2c24846a9f9caa42f5370f192c3d40 @droark Could you post a screenshot of the out of place icons for reference?

  16. theuni approved
  17. theuni commented at 4:27 PM on February 14, 2018: member

    utACK fc1bfcf9fd2c24846a9f9caa42f5370f192c3d40. Thanks!

  18. droark commented at 7:48 PM on February 14, 2018: contributor

    Thanks, everyone! @fanquake - Here you go.

    image

  19. theuni commented at 8:18 PM on February 14, 2018: member

    @droark You just have hidden files showing. That's normal.

  20. droark commented at 8:23 PM on February 14, 2018: contributor

    @theuni - Oh no, I understand the hidden folders. :) I just seemed to recall some issue/PR from awhile back where something similar was discussed, and how the macOS builds put the icons in odd places. I thought it had been resolved? I can't remember where I saw all this, though, and I could be wrong. Better safe than sorry!

    EDIT: Again, just to be clear, I was able to install the build without any problems, and I ran it for awhile on my Mac. This is purely a cosmetic issue, AFAIK. I wouldn't have even brought it up were it not for this being a depends upgrade.

  21. thijstriemstra commented at 8:26 PM on February 14, 2018: none

    @droark what version of macOS are you using?

  22. droark commented at 8:27 PM on February 14, 2018: contributor

    @thijstriemstra - 10.13.3.

  23. fanquake removed this from the milestone Future on Feb 15, 2018
  24. fanquake approved
  25. fanquake commented at 11:35 AM on February 15, 2018: member

    utACK fc1bfcf

  26. laanwj merged this on Feb 15, 2018
  27. laanwj closed this on Feb 15, 2018
  28. laanwj referenced this in commit ae0fbf0981 on Feb 15, 2018
  29. droark deleted the branch on Jun 28, 2018
  30. PastaPastaPasta referenced this in commit 930af8d1ba on Jun 10, 2020
  31. PastaPastaPasta referenced this in commit 04dac120f2 on Jun 11, 2020
  32. PastaPastaPasta referenced this in commit fc3449625e on Jun 11, 2020
  33. gades referenced this in commit c881b35db1 on Jun 24, 2021
  34. CryptoCentric referenced this in commit a8e9761558 on Jul 2, 2021
  35. MarcoFalke locked this on Sep 8, 2021
Contributors
droarkthijstriemstrajonasschnellilaanwjfanquaketheuni
Labels
Build system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 21:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me