Native ds_store python package is not python3 compatible #8134

issue jonasschnelli opened this issue on June 2, 2016
  1. jonasschnelli commented at 7:48 AM on June 2, 2016: contributor

    This tools is required to build a OSX disk image (make deploy). https://github.com/bitcoin/bitcoin/blob/a6a860796a44a2805a58391a009ba22752f64e32/depends/packages/native_ds_store.mk

    The tool is currently not python3 compatible (uses basestring).

    Upstream: https://bitbucket.org/al45tair/ds_store/

  2. jonasschnelli added the label MacOSX on Jun 2, 2016
  3. jonasschnelli added the label Build system on Jun 2, 2016
  4. laanwj commented at 6:46 AM on June 6, 2016: member

    I did submit this upstream: https://bitbucket.org/al45tair/mac_alias/pull-requests/4/further-python-3-compatiblity/diff

    ds_store needed no changes by me, at least.

  5. laanwj commented at 1:19 PM on June 6, 2016: member

    Apparently this is another library that requires porting to Python 3. As this is a native tool and I don't have a mac available to test this so I can't be of help here.

  6. jonasschnelli referenced this in commit e022463a4b on Oct 9, 2017
  7. thijstriemstra commented at 6:20 PM on January 31, 2018: none

    Looks like the Python3 patch in question can be found here: https://github.com/bitcoin/bitcoin/blob/master/depends/patches/native_mac_alias/python3.patch

    The patch was also submitted as a pull request by @droark: https://github.com/al45tair/mac_alias/pull/3

    So native_mac_alias needs to apply the patch and release a new version.

  8. droark commented at 4:11 PM on February 12, 2018: contributor

    Hello. My patch that @thijstriemstra referenced was just pulled. I don't think there's a new release out yet, though. I'm going to go ahead and make a PR that deletes this patch from the Core repo. I don't expect or want it to be deleted just yet, and the patch will need to update the depends once a new version comes out. It'll just be there for when it's needed.

  9. meshcollider commented at 5:16 AM on March 13, 2018: contributor

    Looks like this was addressed in #12417, closing issue now

  10. meshcollider closed this on Mar 13, 2018

  11. PastaPastaPasta referenced this in commit 69b1718805 on Jan 31, 2020
  12. PastaPastaPasta referenced this in commit 61b061c1bb on Jan 31, 2020
  13. PastaPastaPasta referenced this in commit 836c602b0d on Feb 4, 2020
  14. PastaPastaPasta referenced this in commit a592123640 on Feb 9, 2020
  15. CryptoCentric referenced this in commit eb30d5851f on Feb 16, 2020
  16. ckti referenced this in commit 27d48f1df1 on Mar 28, 2021
  17. CryptoCentric referenced this in commit 8bc492d267 on Apr 6, 2021
  18. CryptoCentric referenced this in commit c4e6478d36 on Jul 2, 2021
  19. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me