Declare CMutableTransaction a struct in rawtransaction.h #12494

pull Empact wants to merge 1 commits into bitcoin:master from Empact:mutabletransaction-struct changing 1 files +1 −1
  1. Empact commented at 10:17 PM on February 20, 2018: member

    Because it's a struct.

    Fix for #10579 - this was called out in code review. #10579 (review)

  2. Declare CMutableTransaction a struct in rawtransaction.h
    Because it's a struct.
    eacc5b24f8
  3. fanquake added the label RPC/REST/ZMQ on Feb 20, 2018
  4. promag commented at 10:50 PM on February 20, 2018: member

    ACK eacc5b2.

  5. fanquake commented at 1:49 AM on February 21, 2018: member

    tACK eacc5b2 Fixes:

      CXX      wallet/libbitcoin_wallet_a-crypter.o
    In file included from rpc/rawtransaction.cpp:20:
    ./rpc/rawtransaction.h:9:1: warning: class 'CMutableTransaction' was previously declared as a struct [-Wmismatched-tags]
    class CMutableTransaction;
    ^
    ./primitives/transaction.h:362:8: note: previous use is here
    struct CMutableTransaction
           ^
    ./rpc/rawtransaction.h:9:1: note: did you mean struct here?
    class CMutableTransaction;
    ^~~~~
    struct
      CXX      wallet/libbitcoin_wallet_a-db.o
    
  6. theuni commented at 3:35 PM on February 21, 2018: member

    Obvious utACK eacc5b24f832b8fde4119622970b4e3f72c069b5

  7. achow101 commented at 6:10 PM on February 21, 2018: member

    ACK eacc5b24f832b8fde4119622970b4e3f72c069b5

  8. MarcoFalke merged this on Feb 21, 2018
  9. MarcoFalke closed this on Feb 21, 2018

  10. MarcoFalke referenced this in commit e4ffcacc21 on Feb 21, 2018
  11. Empact deleted the branch on Feb 21, 2018
  12. PastaPastaPasta referenced this in commit a320bf975e on Dec 11, 2020
  13. PastaPastaPasta referenced this in commit 0d87d008d8 on Dec 12, 2020
  14. PastaPastaPasta referenced this in commit af917fedae on Dec 12, 2020
  15. PastaPastaPasta referenced this in commit 5574b51570 on Dec 15, 2020
  16. PastaPastaPasta referenced this in commit d72f7c86f9 on Dec 15, 2020
  17. PastaPastaPasta referenced this in commit 1d90698b6c on Dec 18, 2020
  18. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me