Docs: Minor description fix to build procedure on Debian wrt BerkeleyDB #12526

shigeya commented at 1:28 PM on February 24, 2018: contributor

There is some unclear description on this, and I have confused. Trying to be clear on options.

Verified on Debian 9.3.

fanquake added the label Docs on Feb 24, 2018

fanquake deleted a comment on Feb 24, 2018

in doc/build-unix.md:96 in 5c7e465513 outdated

 102 |  
 103 | -Ubuntu and Debian have their own libdb-dev and libdb++-dev packages, but these will install
 104 | -BerkeleyDB 5.1 or later, which break binary wallet compatibility with the distributed executables which
 105 | -are based on BerkeleyDB 4.8. If you do not care about wallet compatibility,
 106 | -pass `--with-incompatible-bdb` to configure.
 107 | +- Find and install Berkeley DB 4.8 for full binaruy compatibility

practicalswift commented at 4:30 PM on February 24, 2018:

"Binary" typo :-)

shigeya commented at 10:04 PM on February 24, 2018:

:< thanks.

shigeya commented at 10:09 PM on February 24, 2018:

Fixed.

in doc/build-unix.md:88 in 5c7e465513 outdated

  84 | @@ -85,22 +85,27 @@ install necessary parts of boost:
  85 |  
  86 |          sudo apt-get install libboost-all-dev
  87 |  
  88 | -BerkeleyDB is required for the wallet.
  89 | +BerkeleyDB is required for the wallet. Unfortunately, There is a binary incompatibility between BerkeleyDB 4.8 and latest 5.x series. There are three options:

practicalswift commented at 4:31 PM on February 24, 2018:

"There" should be in lower-case :-)

shigeya commented at 11:10 PM on February 24, 2018:

fixed :< thanks.

shigeya force-pushed on Feb 24, 2018

bedri commented at 10:22 PM on February 24, 2018: none

+- Find and install Berkeley DB 4.8 for full binaruy compatibility

There is a typo in the word "binary"

On Sun, Feb 25, 2018 at 1:10 AM, Shigeya Suzuki notifications@github.com wrote:

@shigeya commented on this pull request.

In doc/build-unix.md https://github.com/bitcoin/bitcoin/pull/12526#discussion_r170433970:

-Ubuntu and Debian have their own libdb-dev and libdb++-dev packages, but these will install -BerkeleyDB 5.1 or later, which break binary wallet compatibility with the distributed executables which -are based on BerkeleyDB 4.8. If you do not care about wallet compatibility, -pass --with-incompatible-bdb to configure. +- Find and install Berkeley DB 4.8 for full binaruy compatibility

Fixed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/12526#discussion_r170433970, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuuLzy4L8wc8xBlInYdMK1R5ObcuC_Yks5tYIi5gaJpZM4SR5FU .

practicalswift approved

in doc/build-unix.md:90 in 65e8d7fc94 outdated

  84 | @@ -85,22 +85,27 @@ install necessary parts of boost:
  85 |  
  86 |          sudo apt-get install libboost-all-dev
  87 |  
  88 | -BerkeleyDB is required for the wallet.
  89 | +BerkeleyDB is required for the wallet. Unfortunately, There is a binary incompatibility between BerkeleyDB 4.8 and latest 5.x series. There are three options:
  90 |  
  91 | -**For Ubuntu only:** db4.8 packages are available [here](https://launchpad.net/~bitcoin/+archive/bitcoin).
  92 | -You can add the repository and install using the following commands:
  93 | +- If you need the wallet and don't need the binary wallet compatibility install latest Berkeley DB with following commands:

practicalswift commented at 10:23 PM on February 24, 2018:

Nit: "Install the latest …"

shigeya commented at 11:10 PM on February 24, 2018:

fixed :< thanks.

shigeya force-pushed on Feb 24, 2018

randolf approved

in doc/build-unix.md:93 in b3aa18f078 outdated

  95 | -    sudo apt-get install software-properties-common
  96 | -    sudo add-apt-repository ppa:bitcoin/bitcoin
  97 | -    sudo apt-get update
  98 | -    sudo apt-get install libdb4.8-dev libdb4.8++-dev
  99 | +        sudo apt-get install libdb-dev libdb++-dev
 100 | +

AkioNak commented at 12:45 PM on February 28, 2018:

@shigeya perhaps the whitespace in this line made travis-check to fail.

shigeya commented at 1:11 PM on February 28, 2018:

Oh, I see. let me push another one.

shigeya force-pushed on Feb 28, 2018

shigeya commented at 10:47 PM on February 28, 2018: contributor

Hmm. Looks like intentional trailing space (to adjust indentation of the following text) for formatting cause the issue. I will look into the lint code, but, simply forbid such a trailing space don't work in this context. I tried to rewrite the text prior the apt-get commands but can't find a better way to rewrite. Will fix in either way.

in doc/build-unix.md:82 in 61cfc4a111 outdated

  78 | @@ -79,28 +79,33 @@ Options when installing required Boost library files:
  79 |  individual boost development packages, so the following can be used to only
  80 |  install necessary parts of boost:
  81 |  
  82 | -        sudo apt-get install libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-program-options-dev libboost-test-dev libboost-thread-dev
  83 | +    sudo apt-get install libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-program-options-dev libboost-test-dev libboost-thread-dev

AkioNak commented at 1:44 AM on March 1, 2018:

I think that it is better not to delete whitespace here. If there are only 4, it seems that no code block is generated.

in doc/build-unix.md:86 in 61cfc4a111 outdated

  83 | +    sudo apt-get install libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-program-options-dev libboost-test-dev libboost-thread-dev
  84 |  
  85 |  2. If that doesn't work, you can install all boost development packages with:
  86 |  
  87 | -        sudo apt-get install libboost-all-dev
  88 | +    sudo apt-get install libboost-all-dev

AkioNak commented at 1:45 AM on March 1, 2018:

I think that it is better not to delete whitespace here. If there are only 4, it seems that no code block is generated.

in doc/build-unix.md:93 in 61cfc4a111 outdated

  97 | -    sudo apt-get install software-properties-common
  98 | -    sudo add-apt-repository ppa:bitcoin/bitcoin
  99 | -    sudo apt-get update
 100 | -    sudo apt-get install libdb4.8-dev libdb4.8++-dev
 101 | +    sudo apt-get install libdb-dev libdb++-dev
 102 | +

AkioNak commented at 1:51 AM on March 1, 2018:

If there are 6 spaces before sudo apt-get, markdown will generate a code block. Then I think that the space at the end of the next line is unnecessary.

in doc/build-unix.md:104 in 61cfc4a111 outdated

 114 | +      sudo add-apt-repository ppa:bitcoin/bitcoin
 115 | +      sudo apt-get update
 116 | +      sudo apt-get install libdb4.8-dev libdb4.8++-dev
 117 | +
 118 | +- Disabling the wallet
 119 | +

AkioNak commented at 1:59 AM on March 1, 2018:

I think the space at the end of this line is unnecessary.

shigeya commented at 2:11 AM on March 1, 2018:

Thanks, but that lines does not actually cause the problem. The issue is caused by different lines. Please see the log.

AkioNak changes_requested

AkioNak commented at 2:08 AM on March 1, 2018: contributor

I'm sorry, I confused you with my last comment. I reviewed again with editing my local repository actually.

Minor description fix to build procedure on Debian wrt BerkeleyDB

There is some unclear description on this, and I have confused.
Trying to be clear on options.

3839396aea

shigeya force-pushed on Mar 2, 2018

shigeya commented at 4:31 AM on March 2, 2018: contributor

I have modified to eliminate description trailing in apt-get code block. I will look into the lint code on spare time in future.

fanquake commented at 2:45 PM on March 14, 2018: member

@shigeya Are you planning on following up with the changes needed here?

shigeya commented at 3:09 PM on March 14, 2018: contributor

@fanquake yes. I will. bit busy last two weeks.

MarcoFalke commented at 7:31 PM on April 11, 2018: member

Closing for now. You can open a new pull request when you come back to addressing the feedback.

MarcoFalke closed this on Apr 11, 2018

MarcoFalke locked this on Sep 8, 2021

Docs: Minor description fix to build procedure on Debian wrt BerkeleyDB #12526

@shigeya commented on this pull request.