qa: Fix some tests to work on native windows #12627

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1803-qaWindowsTests changing 3 files +19 −12

MarcoFalke commented at 11:43 PM on March 6, 2018: member

This allows some more tests to be run natively on Windows
qa: Fix some tests to work on native windows fa3528a85b
in test/functional/wallet_dump.py:143 in fa3528a85b
```
 141 |          assert_equal(found_addr_rsv, 90*2) 
 142 |          assert_equal(witness_addr_ret, witness_addr)
 143 |  
 144 |          # Overwriting should fail
 145 | -        assert_raises_rpc_error(-8, "already exists", self.nodes[0].dumpwallet, tmpdir + "/node0/wallet.unencrypted.dump")
 146 | +        assert_raises_rpc_error(-8, "already exists", lambda: self.nodes[0].dumpwallet(wallet_enc_dump))
```
NicolasDorier commented at 1:18 AM on March 7, 2018:

should be wallet_unenc_dump

MarcoFalke commented at 3:42 AM on March 7, 2018:

Both exists, so it shouldn't matter when we are just testing that overwriting fails.

Also, the last calls to node 0 are to encrypt and then dump the encrypted wallet. So imo it is easier to understand the code (with less context) if we try to overwrite the dump of the encrypted wallet.
jonasschnelli added the label Windows on Mar 7, 2018
jonasschnelli added the label Tests on Mar 7, 2018

MarcoFalke commented at 3:47 AM on March 7, 2018: member

Should fix the following issues:

mempool_persists:

FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'C:\\Users\\win\\AppData\\Local\\Temp\\1\\bitcoin_test_runner_20180306_225759\\mempool_persist_612\\node0\\regtest\\mempool.dat' -> 'C:\\Users\\win\\AppData\\Local\\Temp\\1\\bitcoin_test_runner_20180306_225759\\mempool_persist_612\\node1\\regtest\\mempool.dat'

feature_proxy:

ImportError: No module named 'fcntl'

wallet_dump:

AssertionError: not(C:\Users\win\AppData\Local\Temp\1\bitcoin_test_runner_20180306_225759\wallet_dump_636/node0/wallet.unencrypted.dump == C:\Users\win\AppData\Local\Temp\1\bitcoin_test_runner_20180306_225759\wallet_dump_636\node0\wallet.unencrypted.dump)

practicalswift commented at 6:17 AM on March 7, 2018: contributor

utACK fa3528a85b05ea9507077f3eb340c9fb189251a6
NicolasDorier commented at 1:20 PM on March 7, 2018: contributor

utACK fa3528a85b05ea9507077f3eb340c9fb189251a6
MarcoFalke merged this on Mar 7, 2018
MarcoFalke closed this on Mar 7, 2018
MarcoFalke referenced this in commit 791c3ea61b on Mar 7, 2018
MarcoFalke deleted the branch on Mar 7, 2018
deadalnix referenced this in commit fda14e4160 on May 5, 2020
PastaPastaPasta referenced this in commit 3589a192df on Jun 13, 2020
PastaPastaPasta referenced this in commit d35e410aea on Jun 13, 2020
PastaPastaPasta referenced this in commit 55347dd9cd on Jun 17, 2020
PastaPastaPasta referenced this in commit e329fd562b on Jun 18, 2020
ftrader referenced this in commit 083b84b026 on Aug 17, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels