rpc: importmulti improvements #12703

issue fanquake openend this issue on March 16, 2018
  1. fanquake commented at 1:50 am on March 16, 2018: member

    Some comments from @sipa in #12702.


    Yes, I think importmulti is superior in every way, except:

    • Slightly less convenient to use (it requires redundant information, as you have to explicitly state what you want to import, and then give the keys/… to enable that).
    • Doesn’t support P2SH-P2WPKH yet. Added in #14454

    The latter can be fixed by just adding support for that case. The former can be improved by adding ‘default’ cases (e.g. if you prove a WIF private key, it can permit omitting the address, …).

  2. fanquake added the label RPC/REST/ZMQ on Mar 16, 2018
  3. ryanofsky commented at 3:10 pm on March 16, 2018: member
    If this is supposed to be a bucket issue for importmulti improvments, #9332 is a simplification to importmulti that makes it less restrictive about accepting labels.
  4. laanwj referenced this in commit b312579c69 on Oct 31, 2018
  5. meshcollider commented at 5:24 am on November 12, 2018: contributor
    Second comment addressed in #14454, now merged
  6. jarolrod commented at 5:47 am on January 14, 2021: member
    @fanquake @ryanofsky can this be closed? #9332 and #14454 appear to have addressed both bullet points and are now merged.
  7. ryanofsky commented at 6:31 am on January 14, 2021: member
    Seems fine to close. It can be reopened if there’s more discussion. Or more specific issues can be created. I don’t think that the first bullet point’s been addressed in any way since this was opened but it doesn’t seem to be making a specific request.
  8. ryanofsky closed this on Jan 14, 2021

  9. PastaPastaPasta referenced this in commit 5b5bcb5fbd on Sep 18, 2021
  10. UdjinM6 referenced this in commit 908b6e6535 on Sep 28, 2021
  11. kittywhiskers referenced this in commit 5f308252d1 on Oct 12, 2021
  12. DrahtBot locked this on Aug 18, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-18 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me