log: Be less confusing in the way we inform the user that logging has started #12707

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:scrolling-can-be-fun-but-this-is-too-much-fun changing 1 files +1 −2

practicalswift commented at 3:12 PM on March 16, 2018: contributor

Be less confusing in the way we inform the user that logging has started.

Before this patch:

$ src/bitcoind -printtoconsole
2018-03-16T13:07:59Z



















2018-03-16T13:07:59Z Bitcoin Core version v0.16.99.0-7be9a9a (release build)
…

After this patch:

$ src/bitcoind -printtoconsole
2018-03-16T13:07:59Z Bitcoin Core version v0.16.99.0-7be9a9a (release build). Logging started.
…

log: Be less confusing in the way we inform the user that logging has started (usability) 448d46d203
instagibbs commented at 4:08 PM on March 16, 2018: member

doesn't this remove the pretty helpful gap in logging for visual scrolling between instances? I suppose I should memorize a good phrase to grep for, but alas.
fanquake added the label Utils/log/libs on Mar 16, 2018
donaloconnor commented at 6:16 PM on March 16, 2018: contributor

Similar concerns to @instagibbs . I think I'd prefer the spaces in the log file especially. Also might slightly overlap with work here: #12689
fanquake commented at 3:33 AM on March 17, 2018: member

Yea, I'm going to close this until #12689 is finished.
fanquake closed this on Mar 17, 2018
practicalswift commented at 8:19 PM on April 26, 2018: contributor

I don't think this change is needed anymore since the newlines are no longer printed to the console. They are now only printed to the log file where they make sense in order to distinguish between two subsequent sessions. So let's keep this one closed! :-)
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

Labels