[RPC] Remove unreachable help conditions in rpcwallet.cpp #12727

pull lutangar wants to merge 1 commits into bitcoin:master from LePetitBloc:unreachable-help-condition changing 1 files +0 −8

lutangar commented at 4:09 PM on March 19, 2018: contributor
These conditions on request.fHelp, which appears in the body of the following functions are never reached:
- walletpassphrase
- walletpassphrasechange
- encryptwallet
```
...
    if (request.fHelp || request.params.size() != 0) {
        throw std::runtime_error("");
    }
...
    if (request.fHelp)
        return true;
...
```
The first condition would throw if request.fHelp evaluates to true.
Remove unreachable help conditions e5468a19d1
fanquake added the label RPC/REST/ZMQ on Mar 19, 2018
MarcoFalke renamed this:
~~[RPC][Trivial] Remove unreachable help conditions in `rpcwallet.cpp`~~
[RPC] Remove unreachable help conditions in rpcwallet.cpp
on Mar 19, 2018
MarcoFalke added the label Refactoring on Mar 19, 2018
MarcoFalke commented at 4:19 PM on March 19, 2018: member

utACK e5468a19d14a32715097435df778d43efcceaa11. The code as-is wouldn't make sense anyway
Empact commented at 5:40 PM on March 19, 2018: member

utACK e5468a1
ken2812221 commented at 6:20 PM on March 19, 2018: contributor

utACK e5468a1
practicalswift commented at 6:40 PM on March 19, 2018: contributor

Nice first-time contribution! 👍

utACK e5468a1
donaloconnor commented at 7:09 PM on March 19, 2018: contributor

utACK https://github.com/bitcoin/bitcoin/commit/e5468a19d14a32715097435df778d43efcceaa11
jnewbery commented at 8:47 PM on March 19, 2018: member

utACK e5468a19d14a32715097435df778d43efcceaa11
MarcoFalke merged this on Mar 19, 2018
MarcoFalke closed this on Mar 19, 2018
MarcoFalke referenced this in commit 8ee5c7b747 on Mar 19, 2018
PastaPastaPasta referenced this in commit 75739e4717 on Jun 9, 2020
PastaPastaPasta referenced this in commit 382e625020 on Jun 9, 2020
PastaPastaPasta referenced this in commit 4375e2adca on Jun 10, 2020
PastaPastaPasta referenced this in commit b0a30c4a92 on Jun 11, 2020
PastaPastaPasta referenced this in commit ff4ea5b77b on Jun 11, 2020
PastaPastaPasta referenced this in commit 2799bdd830 on Jun 11, 2020
PastaPastaPasta referenced this in commit 1d911cbe6a on Jun 12, 2020
deadalnix referenced this in commit ebfbffa98b on Jun 15, 2020
gades referenced this in commit adee6a5193 on Jun 30, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Refactoring RPC/REST/ZMQ