tests: Remove unused argument max_invalid from check_estimates(...) #12746

1. 
   practicalswift commented at 9:45 AM on March 21, 2018: contributor

   Remove unused argument max_invalid from check_estimates(...).

   Note to reviewers: Let me know if check_estimates(...) is incomplete and should be fixed instead.

2. tests: Remove unused argument max_invalid from check_estimates(...) a004eb1dae
3. fanquake added the label Tests on Mar 21, 2018
4. 
   practicalswift commented at 9:47 AM on March 21, 2018: contributor

   Last use removed in a5623b1615bdd3e8b23b639c7c6aff04a44dadf7. Friendly ping @jnewbery :-)

5. fanquake requested review from jnewbery on Mar 21, 2018
6. fanquake requested review from morcos on Mar 21, 2018
7. 
   jnewbery commented at 3:55 PM on March 21, 2018: member

   Trival utACK. Not removing this was an oversight in https://github.com/bitcoin/bitcoin/commit/d119f2ec1a3b9213a79de972ed7b9b7022645b3f.

   estimatesmartfee really needs better testing (preferably as a unit test rather than functional), as noted in #12336#issue-166887786

8. 
   fanquake commented at 4:01 PM on March 21, 2018: member

   utACK https://github.com/bitcoin/bitcoin/pull/12746/commits/a004eb1dae7e0aa91e65f73cfc81f87c048b5b5c

9. MarcoFalke merged this on Mar 21, 2018
10. MarcoFalke closed this on Mar 21, 2018

    ---

11. MarcoFalke referenced this in commit 2405ce1df0 on Mar 21, 2018
12. PastaPastaPasta referenced this in commit 32e61f1257 on Dec 16, 2020
13. PastaPastaPasta referenced this in commit 3d4ec1b965 on Dec 18, 2020
14. practicalswift deleted the branch on Apr 10, 2021
15. DrahtBot locked this on Aug 18, 2022

Review Requested
jnewberymorcos