[MOVEONLY] Move compressor utility functions out of class #12752

pull sipa wants to merge 1 commits into bitcoin:master from sipa:201803_movecompress changing 3 files +33 −36
  1. sipa commented at 9:20 pm on March 21, 2018: member

    This is a refactor from #10785 with no functionality change.

    Move the compresion utility functions out of CScriptCompressor, as a preparation for making the class templated. I’m submitting it as a separate PR as I think it’s a general improvement to code readability, and to reduce the diff further on.

  2. Move compressor utility functions out of class 76a9aacd3f
  3. meshcollider added the label Refactoring on Mar 21, 2018
  4. Empact commented at 4:53 am on March 22, 2018: member
    utACK 76a9aac
  5. ryanofsky commented at 1:24 am on March 27, 2018: member
    utACK 76a9aacd3fb75d5e0854e53bb3376f2ab603a561
  6. dcousens approved
  7. dcousens commented at 1:57 am on March 27, 2018: contributor
    utACK
  8. laanwj commented at 11:04 am on March 30, 2018: member
    Agree with the change overall. Namespacing is good, but classes shouldn’t be used for that. For readability, functions that do nothing with the instance or class state are better as utility functions. utACK 76a9aacd3fb75d5e0854e53bb3376f2ab603a561
  9. laanwj merged this on Mar 30, 2018
  10. laanwj closed this on Mar 30, 2018

  11. laanwj referenced this in commit d2d7267e23 on Mar 30, 2018
  12. Fabcien referenced this in commit a8d8cd1375 on Aug 30, 2019
  13. jonspock referenced this in commit d9624db257 on Dec 8, 2019
  14. jonspock referenced this in commit 91247e896b on Dec 8, 2019
  15. jonspock referenced this in commit 36223e90be on Dec 8, 2019
  16. proteanx referenced this in commit 777382808d on Dec 12, 2019
  17. kittywhiskers referenced this in commit 1d95dc78e4 on Mar 16, 2021
  18. kittywhiskers referenced this in commit 4bedbe28dc on Mar 16, 2021
  19. PastaPastaPasta referenced this in commit 2f542a93a1 on Apr 18, 2021
  20. UdjinM6 referenced this in commit 20b71700dc on May 14, 2021
  21. kittywhiskers referenced this in commit c9f61df21e on May 20, 2021
  22. furszy referenced this in commit 5c93f159bc on Jul 5, 2021
  23. random-zebra referenced this in commit b4751e10ce on Aug 11, 2021
  24. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me