Bugfix: Include <memory> for std::unique_ptr #12859

1. 
   luke-jr commented at 6:33 PM on April 2, 2018: member

   Not sure why all these includes were missing, but it's breaking builds for some users:

   https://bugs.gentoo.org/show_bug.cgi?id=652142

   (Added to all files with a reference to std::unique_ptr)

2. Bugfix: Include <memory> for std::unique_ptr a5bca13095
3. 
   randolf commented at 7:05 PM on April 2, 2018: contributor

   This doesn't compile on NetBSD 7.0 (64-bit), but the unmodified branch builds as expected. It seems that these updates prevent the check for "-ldb_cxx" from succeeding, even though Berkeley DB4 is already installed.

   STEPS

   git clone https://www.github.com/luke-jr/bitcoin
   cd bitcoin
   git checkout incl_memory
   ./autogen.sh
   ./configure CPPFLAGS="-I/usr/pkg/include" LDFLAGS="-L/usr/pkg/lib" BOOST_CPPFLAGS="-I/usr/pkg/include" BOOST_LDFLAGS="-L/usr/pkg/lib"
   

   OUTCOME

   checking for Berkeley DB C++ headers... /usr/pkg/include/db4/
   checking for main in -ldb_cxx-4.8... no
   checking for main in -ldb_cxx... no
   configure: error: libdb_cxx missing, Bitcoin Core requires this library for wallet functionality (--disable-wallet to disable wallet functionality)
   

   If a change is needed for the ./configure command, I'd be happy to add it to the documentation for the NetBSD installation instructions to accommodate this Pull Request.

   Thanks.

4. 
   luke-jr commented at 7:09 PM on April 2, 2018: member

   Don't use PR branches directly (this one is based on the last common commit between 0.15 and master, for maximum merge-compatibility). Merge it into master to test.

   (This shouldn't change anything during configure.)

5. 
   randolf commented at 7:10 PM on April 2, 2018: contributor

   @luke-jr I'm still learning how to use git, et al., so I welcome any suggestions on the proper way to attempt to compile with your changes.

6. 
   luke-jr commented at 7:12 PM on April 2, 2018: member

   git clone https://www.github.com/bitcoin/bitcoin
   cd bitcoin
   git fetch https://www.github.com/luke-jr/bitcoin incl_memory
   git merge FETCH_HEAD
   ./autogen.sh
   ./configure CPPFLAGS="-I/usr/pkg/include" LDFLAGS="-L/usr/pkg/lib" BOOST_CPPFLAGS="-I/usr/pkg/include" BOOST_LDFLAGS="-L/usr/pkg/lib"
   

7. 
   randolf commented at 7:54 PM on April 2, 2018: contributor

   ACK. @luke-jr Thanks, that worked, and it compiled successfully on NetBSD.

8. randolf approved
9. fanquake added the label Refactoring on Apr 2, 2018
10. 
    luke-jr commented at 10:42 PM on April 2, 2018: member

    @fanquake This should be "Bug", not "Refactoring"...

11. fanquake added the label Bug on Apr 2, 2018
12. fanquake removed the label Refactoring on Apr 2, 2018
13. 
    promag commented at 10:48 PM on April 3, 2018: member

    utACK a5bca13.

14. 
    sipa commented at 10:51 PM on April 3, 2018: member

    utACK a5bca13095aa835d61f872081fc0cc2fa53552f3

15. 
    practicalswift commented at 11:17 AM on April 4, 2018: contributor

    utACK a5bca13095aa835d61f872081fc0cc2fa53552f3. i686-w64-mingw32 build timeout is unrelated.

16. laanwj merged this on Apr 5, 2018
17. laanwj closed this on Apr 5, 2018

    ---

18. laanwj added this to the milestone 0.16.2 on Jun 13, 2018
19. laanwj added the label Needs backport on Jun 13, 2018
20. fanquake referenced this in commit 18b0c69e2f on Jun 13, 2018
21. 
    fanquake commented at 12:02 AM on June 26, 2018: member

    Added to #13455 for backport.

22. fanquake removed the label Needs backport on Jun 26, 2018
23. laanwj referenced this in commit dac5374cce on Jul 9, 2018
24. HashUnlimited referenced this in commit 6eff73e3fa on Jan 11, 2019
25. PastaPastaPasta referenced this in commit d86462cb1c on Jun 10, 2020
26. PastaPastaPasta referenced this in commit b30ade01c9 on Jun 10, 2020
27. PastaPastaPasta referenced this in commit 60be76affc on Jun 10, 2020
28. MarcoFalke locked this on Sep 8, 2021

Milestone
0.16.2