scripted-diff: Remove redundant license reference (HTTP URL) #12914

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:copyright-headers changing 620 files +621 −1239

practicalswift commented at 12:37 PM on April 8, 2018: contributor
As discussed in "up for grabs" PR #12192:
- Remove redundant license reference (see #12192 (comment))
fanquake added the label Docs on Apr 8, 2018
MarcoFalke commented at 2:55 PM on April 8, 2018: member

Just to mention, that our license file is not contained if someone downloads an individual file only.
practicalswift commented at 7:27 AM on April 9, 2018: contributor

@MarcoFalke From a licensing perspective the contained text "MIT software license" should hopefully be sufficiently well-defined in case someone downloads an individual file only, don't you think?
practicalswift force-pushed on Apr 22, 2018
practicalswift commented at 9:43 AM on April 22, 2018: contributor

Rebased. Please review :-)
practicalswift force-pushed on Apr 24, 2018
practicalswift commented at 8:02 PM on April 24, 2018: contributor

Rebased!
practicalswift force-pushed on Apr 26, 2018
practicalswift commented at 4:25 AM on April 26, 2018: contributor

Rebased!
practicalswift force-pushed on Apr 26, 2018
practicalswift force-pushed on Apr 29, 2018
practicalswift renamed this:
~~scripted-diff: Remove redundant license reference (HTTP URL). Update copyright year.~~
scripted-diff: Remove redundant license reference (HTTP URL)
on Apr 29, 2018
practicalswift commented at 6:25 PM on April 29, 2018: contributor

Rebased! No longer touching copyright year to keep this PR focused.

scripted-diff: Remove redundant license reference from license header

-BEGIN VERIFY SCRIPT-

git grep -l "http://www.opensource.org/licenses/mit-license.php" -- "*.py" "*.in" "*.h" "*.cpp" "*.sh" "*.mm" "*.am" "*.m4" "*.bash-completion" "*.svg" "*.include" | grep -vE "(src/crypto/ctaes/|src/univalue/|src/secp256k1/|\.rc$)" | xargs sed -i '/file COPYING or http:\/\/www.opensource.org\/licenses\/mit-license.php./d'
git grep -l "Distributed under the MIT software license, see the accompanying$" -- "*.py" "*.in" "*.h" "*.cpp" "*.sh" "*.mm" "*.am" "*.m4" "*.bash-completion" "*.svg" "*.include" | grep -vE "(src/crypto/ctaes/|src/univalue/|src/secp256k1/|\.rc$)" | xargs sed -i 's/Distributed under the MIT software license, see the accompanying$/Distributed under the MIT software license, see the accompanying file COPYING./g'
git grep -l "COPYING or http://www.opensource.org/licenses/mit-license.php." -- "*.rc" | grep -vE "(src/crypto/ctaes/|src/univalue/|src/secp256k1)" | xargs sed -i 's%COPYING or http://www.opensource.org/licenses/mit-license.php.%COPYING.%g'
sed -i 's/license, see the accompanying file COPYING or/license, see the accompanying file COPYING./g' src/test/data/README.md
sed -i '/http:\/\/www.opensource.org\/licenses\/mit-license.php./d' src/test/data/README.md

-END VERIFY SCRIPT-

176bb1b05f

practicalswift force-pushed on Apr 30, 2018
practicalswift commented at 1:16 PM on April 30, 2018: contributor

Rebased!
MarcoFalke commented at 1:40 PM on April 30, 2018: member

I think this needs some Concept ACK first. If no one comments here, either close it or bring it up in one of the meetings as a short topic.
practicalswift closed this on Apr 30, 2018
ryanofsky commented at 7:00 PM on April 30, 2018: member

utACK 176bb1b05fe3eee7deb1a351adb87d1f76f1c3dc. Since the scripted-diff affects a lot of files, though, I think it would be good to anchor the sed '/PATTERN/d' commands with sed '/^PATTERN$/d' to make sure they are aren't unintentially removing other text or closing comment or quote symbols.

bring it up in one of the meetings as a short topic.

This is a good suggestion for many of your pr's, practicalswift, if you are free Thursdays at 19:00 UTC ( https://bitcoincore.org/en/meetings/)
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#12192 Trivial: Update http URL of MIT license to use https