depends: Fix Qt build with XCode 9.3 #12946

1. 
   fanquake commented at 3:05 pm on April 11, 2018: member

   Building Qt with Xcode 9.3 is currently broken with:

   0compiling kernel/qmacgesturerecognizer.cpp
   1fontdatabases/mac/qfontengine_coretext.mm:775:20: error: qualified reference to 'QFixed' is a constructor name rather than a type in this context
   2    return QFixed::QFixed(int(CTFontGetUnitsPerEm(ctfont)));
   3                   ^
   4compiling .moc/moc_qfbscreen_p.cpp
   51 error generated.
   6make[2]: *** [.obj/qfontengine_coretext.o] Error 1
   7make[2]: *** Waiting for unfinished jobs....
   

   This patch should fix that, and will hopefully be the last time we have to patch Qt 5.7.

   I’ve only made minor adjustments from the original patch, so that it will apply, although still not completely cleanly. We can cleanup if required.

2. depends: Fix Qt build with XCode 9.3 5b4fc3eca4
3. fanquake added the label macOS on Apr 11, 2018
4. fanquake added the label Build system on Apr 11, 2018
5. fanquake requested review from theuni on Apr 11, 2018
6. 
   practicalswift commented at 3:27 pm on April 11, 2018: contributor

   Concept ACK
7. 
   Sjors commented at 6:25 pm on April 11, 2018: member

   I was initially confused by the PR description into thinking bitcoin-qt didn’t build, but you’re referring to QT itself via the depends system.

   I didn’t try before updating the command line tools in Xcode 9.3, but indeed building QT on macOS 10.13.4 is broken for me:

    0cd depends
    1make
    2...
    3compiling util/qundoview.cpp
    4rm -f ../../lib/libQt5Widgets.a
    5/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ar cq ../../lib/libQt5Widgets.a .obj/qaction.o .obj/qactiongroup.o .obj/qapplication.o
    6...
    7.obj/moc_qmacstyle_mac_p.o .obj/moc_qmacnativewidget_mac.o .obj/moc_qmaccocoaviewcontainer_mac.o
    8/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../lib/libQt5Widgets.a(qstylepainter.o) has no symbols
    9...
   10/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../lib/libQt5Widgets.a(qscroller_mac.o) has no symbols
   11make: *** [/Volumes/SSD/src/bitcoin/depends/work/build/x86_64-apple-darwin17.5.0/qt/5.7.1-78660355bf0/qtbase/.stamp_built] Error 2
   

   This PR fixes it for me.

8. theuni approved
9. 
   theuni commented at 10:53 pm on April 12, 2018: member

   utACK 5b4fc3eca429456628a5db4e4090da294eb1eba1
10. laanwj merged this on Apr 14, 2018
11. laanwj closed this on Apr 14, 2018

    ---

12. laanwj referenced this in commit e76acf3384 on Apr 14, 2018
13. fanquake referenced this in commit 7458d51eca on Apr 18, 2018
14. MarcoFalke referenced this in commit e2510a3b0e on Apr 20, 2018
15. fanquake referenced this in commit e055bc0fdf on Apr 26, 2018
16. fanquake referenced this in commit 93b9a61f12 on Apr 26, 2018
17. laanwj referenced this in commit 1618c63095 on May 15, 2018
18. laanwj referenced this in commit feba12fe85 on May 16, 2018
19. XNotCopy referenced this in commit 4cbc53b5c9 on Jun 21, 2018
20. HashUnlimited referenced this in commit 5e608bacc0 on Jun 29, 2018
21. whatevercode referenced this in commit c5748461bd on Jul 14, 2018
22. ccebrecos referenced this in commit eb88ecfd7a on Sep 14, 2018
23. UdjinM6 referenced this in commit b652a91696 on Sep 25, 2018
24. UdjinM6 referenced this in commit 8d010c6904 on Sep 26, 2018
25. codablock referenced this in commit 5cf7253298 on Sep 28, 2018
26. codablock referenced this in commit 199717354f on Sep 28, 2018
27. codablock referenced this in commit d817a38d9b on Sep 28, 2018
28. UdjinM6 referenced this in commit 8a1b513560 on Sep 30, 2018
29. UdjinM6 referenced this in commit 9a3d44eddc on Oct 3, 2018
30. CryptoCentric referenced this in commit 2b0670db2d on Mar 13, 2019
31. fanquake deleted the branch on Jan 22, 2020
32. DrahtBot locked this on Feb 15, 2022

Contributors
fanquake practicalswift Sjors theuni

Labels
macOS Build system