Drop dead code CScript::Find #12969

pull Empact wants to merge 1 commits into bitcoin:master from Empact:cscript-find changing 1 files +0 −9

Empact commented at 8:48 PM on April 12, 2018: member

Last use removed in 922e8e2 (2012!)
Empact commented at 8:50 PM on April 12, 2018: member

Do we have a mechanism for dead code detection?
MarcoFalke commented at 8:53 PM on April 12, 2018: member

Please include in what commit it was last used.
Empact force-pushed on Apr 12, 2018
Empact commented at 9:11 PM on April 12, 2018: member

@MarcoFalke 922e8e2 (2012!)
fanquake added the label Refactoring on Apr 12, 2018
jimpo commented at 1:28 AM on April 13, 2018: contributor

utACK c6d4a81.

grepped codebase for Find(. Other instances found are CAddrMan::Find and FindFileTest::Find in leveldb.
Empact commented at 1:34 AM on April 13, 2018: member

The test failure is known issue #12863

Drop dead code CScript::Find

Last use removed in 922e8e2929a2e78270868385aa46f96002fbcff3 (2012!)

8cbc5c4be4

Empact force-pushed on Apr 13, 2018
Empact commented at 1:57 AM on April 13, 2018: member

Rebased for CI
ajtowns commented at 5:01 AM on April 13, 2018: member

NACK 8cbc5c4be4be22aca228074f087a374a7ec38be8 -- code is fine, but it introduces a merge conflict with #12885 due to being adjacent in the file being patched, so this should be rebased after that is merged IMO.
practicalswift commented at 5:30 AM on April 13, 2018: contributor

utACK 8cbc5c4be4be22aca228074f087a374a7ec38be8

I don't see any Find(…) usage being removed in 922e8e2?

My reading is that Find(…) has been unused since being introduced in e679ec969c8b22c676ebb10bea1038f6c8f13b33.

Anyways – nice find!

Edit: Found the removed usage. GitHub's interface tricked me :-)
ajtowns commented at 6:19 AM on April 13, 2018: member

@practicalswift There's subscript.Find(OP_CODESEPERATOR), scriptPubKey.Find(OP_EVAL) and scriptSig.Find(OP_EVAL) removed in that commit. Github hides them with a "Large diffs are not rendered by default." though.
laanwj commented at 6:41 AM on April 13, 2018: member

drop dead code :mouse: utACK 8cbc5c4be4be22aca228074f087a374a7ec38be8
sipa commented at 8:35 AM on April 13, 2018: member

Drop dead, code! utACK 8cbc5c4be4be22aca228074f087a374a7ec38be8 @ajtowns I'll gladly rebase #12885 if this is merged first.
Empact commented at 8:58 AM on April 13, 2018: member

@sipa likewise on this side :)
promag commented at 10:45 AM on April 13, 2018: member

@ajtowns sorry you mean @practicalswift?
promag commented at 10:46 AM on April 13, 2018: member

utACK 8cbc5c4.
laanwj merged this on Apr 13, 2018
laanwj closed this on Apr 13, 2018
laanwj referenced this in commit 94deb09349 on Apr 13, 2018
Empact deleted the branch on Apr 17, 2018
jasonbcox referenced this in commit cdbd298380 on Aug 16, 2019
jonspock referenced this in commit a03c73daa7 on Nov 4, 2019
proteanx referenced this in commit 147e01b82e on Nov 4, 2019
PastaPastaPasta referenced this in commit 689a5d21e1 on Jun 17, 2020
PastaPastaPasta referenced this in commit bd6f399d78 on Jun 17, 2020
PastaPastaPasta referenced this in commit 0036b30685 on Jun 27, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels