Add python3 script shebang lint #12972

base58.py can executed by python3

Good candidate for a lint?

To the best of my knowledge, the script is outdated and won't produce test vectors in the current format. Since you are touching this file, might as well fix this in one go?

Also the readme should be updated to reflect the new names, i.e. "src/test/data/key_io_valid.json" and "src/test/data/key_io_invalid.json"

@Empact The linter you're thinking about would check that all *.py files start with #!/usr/bin/env python3? Anything more?

@MarcoFalke since we don't generate testdata dynamically, should we delete this testgen directory?

I don't know how to deal with contrib/devtools/test-security-check.py, it seems outdated, and not python3 code

Concept ACK adding the linter, however it should only return an error if there's a python or python2 shebang. It's fine to have no shebang if the module is not intended to be run as a standalone executable.

I don't think we should add shebangs to modules which aren't intended to be run as standalone executables.

test-security-check.py was overlooked in #11881. You can convert it to Python3 with the following commit: https://github.com/jnewbery/bitcoin/commit/35cb5dafdd5d08ed536971ae9401c56f98b4f421

@ken2812221 What about this linter?

#!/bin/bash

EXIT_CODE=0
for PYTHON_FILE in $(git ls-files -- "*.py"); do
    if [[ $(head -c 2 "${PYTHON_FILE}") == "#!" &&
          $(head -n 1 "${PYTHON_FILE}") != "#!/usr/bin/env python3" ]]; then
        echo "Missing shebang \"#!/usr/bin/env python3\" in ${PYTHON_FILE}"
        EXIT_CODE=1
    fi
done
exit ${EXIT_CODE}

@practicalswift Seems your lint is flexible

@jnewbery thanks

utACK 294e59675bf326eb0e81a6685410f25df5619be4

utACK 2bff472992401b9fecf89622a0151e6fcdab3707

utACK 2bff472

utACK 2bff472992401b9fecf89622a0151e6fcdab3707