Remove unused default args to Invalid and DoS #12991

pull Empact wants to merge 1 commits into bitcoin:master from Empact:remove-unused-default-args-dos changing 1 files +2 −4

Empact commented at 9:27 PM on April 15, 2018: member

These unused default args increase risk related to pending refactoring of these interfaces.

Remove unused default args to Invalid and DoS

These unused default args increase risk related to pending
refactoring of these interfaces.

8d93632e20

Empact commented at 9:29 PM on April 15, 2018: member

After taking a few passes at this refactoring, I realized I want to keep the existing names if possible, so this is a step toward reducing risk associated with that, see: #12976 (comment) #12463 (comment)
meshcollider added the label Refactoring on Apr 16, 2018
practicalswift commented at 6:39 AM on April 16, 2018: contributor

Concept ACK
jnewbery commented at 3:36 PM on April 16, 2018: member

Rather than these minor refactors, I'd much rather see progress made on #11639, which clarifies the interface between net_processing and validation. It'd be a shame to have to rebase that PR and waste the reviewer cycles there. @Empact - how would you feel about reviewing that PR?
Empact commented at 4:39 AM on April 17, 2018: member

@jnewbery Sorry, I'm at stage where I see the codebase more in the small than in the large, and I take the smaller PRs as neatly packaged unambiguous improvements. This was setting us up for this simplification: https://github.com/bitcoin/bitcoin/compare/master...Empact:drop-dos-return-corruption-scripted?expand=1

As for #11639, I like it, I'll make some comments over there. IMO its a bit easier to reason about after applying my changes: https://github.com/bitcoin/bitcoin/compare/master...Empact:2017-10-dos-rewrite?expand=1
Empact commented at 11:36 AM on April 18, 2018: member

@jnewbery thanks for the guidance, will reopen post-#11639
Empact closed this on Apr 18, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels