Validation Interface Logging #12994

1. 
   jnewbery commented at 2:29 pm on April 16, 2018: member

   #12978 was a fun bug where there was a race to enqueue UpdatedBlockTip() between the message handling thread and an RPC thread.

   That issue and others like it would be a lot easier to debug if the validation interface logged whenever a callback is enqueued or dequeued (similar to #12981, but comprehensively covering all validation interface callbacks). @TheBlueMatt - any objections before I PR this?

2. fanquake added the label Validation on Apr 16, 2018
3. fanquake added the label Utils/log/libs on Apr 16, 2018
4. 
   skeees commented at 4:55 pm on April 17, 2018: contributor

   Upvote on enhanced logging - I’m going to attempt some unit tests for well ordered behavior from @sdaftuar’s suggestion
5. 
   Empact commented at 9:45 pm on April 18, 2018: member

   @skeees tests, I presume: #13023
6. 
   jb55 commented at 6:28 pm on September 11, 2018: member

   did anything come of this?
7. 
   jnewbery commented at 6:36 pm on September 11, 2018: member

   did anything come of this?

   No, I moved on to other things. PRs welcome!

8. 
   jkczyz commented at 3:28 am on August 16, 2019: contributor

   I can pick this up. @jnewbery Should all logging here use common BCLog::LogFlags (e.g. BCLog::NET) or should it vary based on the interface method?

   https://github.com/bitcoin/bitcoin/blob/c52776e6ff4dd04c37eaee5fb5cf769ed32c9cac/src/logging.h#L34

9. 
   jnewbery commented at 4:46 pm on August 19, 2019: member

   Should all logging here use common BCLog::LogFlags (e.g. BCLog::NET) or should it vary based on the interface method?

   I think it should be a new logging category (VALIDATIONINTERFACE), since it could be quite noisy and it seems reasonable to be able to turn it on/off individually.

10. jkczyz referenced this in commit 082012a59a on Aug 22, 2019
11. jkczyz referenced this in commit e13e0f85dc on Aug 22, 2019
12. jkczyz referenced this in commit 4bacb541ea on Sep 3, 2019
13. jkczyz referenced this in commit 41eb472399 on Oct 17, 2019
14. jkczyz referenced this in commit e9eadb374e on Oct 17, 2019
15. jkczyz referenced this in commit b6bc83628f on Oct 17, 2019
16. jkczyz referenced this in commit 85f46a257f on Oct 31, 2019
17. jkczyz referenced this in commit 42c6fb596a on Oct 31, 2019
18. jkczyz referenced this in commit 58e9c5f748 on Oct 31, 2019
19. jkczyz referenced this in commit bb65a925b6 on Oct 31, 2019
20. jkczyz referenced this in commit 7f70f63ddf on Oct 31, 2019
21. jkczyz referenced this in commit b77188484f on Oct 31, 2019
22. jkczyz referenced this in commit 93e1e930af on Oct 31, 2019
23. jkczyz referenced this in commit b557294604 on Oct 31, 2019
24. jkczyz referenced this in commit 6ab424c4c1 on Oct 31, 2019
25. jkczyz referenced this in commit 9eb373c07a on Nov 1, 2019
26. jkczyz referenced this in commit b7cb245a21 on Nov 5, 2019
27. jkczyz referenced this in commit f871e272a1 on Nov 5, 2019
28. jnewbery referenced this in commit 45a0e9d0fb on Nov 8, 2019
29. jnewbery referenced this in commit 7058b453af on Nov 8, 2019
30. jkczyz referenced this in commit 5a38eafaf8 on Nov 8, 2019
31. jkczyz referenced this in commit 741cab0a7d on Nov 8, 2019
32. jkczyz referenced this in commit b91682f90b on Nov 11, 2019
33. jkczyz referenced this in commit b929189fb3 on Nov 11, 2019
34. jkczyz referenced this in commit 5150c49f00 on Nov 11, 2019
35. jkczyz referenced this in commit cd6bf9970f on Nov 11, 2019
36. jkczyz referenced this in commit 389d423a25 on Nov 22, 2019
37. jkczyz referenced this in commit b7bb20e0f6 on Nov 22, 2019
38. jkczyz referenced this in commit 0cadb123ba on Nov 22, 2019
39. jkczyz referenced this in commit 428ac70095 on Jan 3, 2020
40. jkczyz referenced this in commit f9abf4ab6d on Jan 3, 2020
41. laanwj closed this on Jan 9, 2020

    ---

42. laanwj referenced this in commit e7f8450357 on Jan 9, 2020
43. sidhujag referenced this in commit 9d38d10d6e on Jan 9, 2020
44. luke-jr referenced this in commit 4dd2f82dad on Jan 12, 2020
45. luke-jr referenced this in commit 28a17585d4 on Feb 9, 2020
46. HashUnlimited referenced this in commit dd8f974e69 on Apr 17, 2020
47. HashUnlimited referenced this in commit 0af60d4d30 on Apr 17, 2020
48. sidhujag referenced this in commit 496411c6bc on Nov 10, 2020
49. backpacker69 referenced this in commit f10180b083 on Mar 28, 2021
50. backpacker69 referenced this in commit fbda4bfb86 on Mar 28, 2021
51. DrahtBot locked this on Feb 15, 2022

Contributors
jnewbery skeees Empact jb55 jkczyz

Labels
Validation Utils/log/libs