Consistently log CValidationState on call failure #13020

pull Empact wants to merge 1 commits into bitcoin:master from Empact:log-cvalidation-state changing 4 files +29 −15
  1. Empact commented at 4:15 PM on April 18, 2018: member

    This replaces potential silent failures and partial logging with full logging. Seems providing at least minimal visibility to the failure is a good practice. E.g. FlushStateToDisk can return a rare but meaningful out of disk space error that would be better to note than leave out.

    Note many of these are related to ActivateBestChain or FlushStateToDisk. Only a few cases of ignored state remain, e.g. LoadExternalBlockFile and RelayWalletTransaction, where I expect logging would likely be spammy.

  2. Empact force-pushed on Apr 18, 2018
  3. practicalswift commented at 10:33 PM on April 18, 2018: contributor

    Concept ACK

  4. Consistently log CValidationState on failure
    Seems providing at least minimal visibility to the failure is a good practice.

The only remaining ignored state is in LoadExternalBlockFile, where logging
would likely be spammy.
    e4d0b44373
  5. Empact force-pushed on Apr 18, 2018
  6. fanquake added the label Utils/log/libs on Apr 20, 2018
  7. laanwj commented at 10:19 AM on April 23, 2018: member

    We removed much of the logging at the place of errors to prevent noisyness in the log. But this seems fair, the added messages are for rare and serious conditions and adding extra diagnostic information to existing messages can't hurt. utACK e4d0b44373c75a597c21a0e93698364fc33fb79d

  8. jonasschnelli commented at 11:57 AM on April 23, 2018: contributor

    Agree with @laanwj. utACK e4d0b44373c75a597c21a0e93698364fc33fb79d

  9. laanwj merged this on Apr 23, 2018
  10. laanwj closed this on Apr 23, 2018
  11. laanwj referenced this in commit 4741ca5dc8 on Apr 23, 2018
  12. Empact deleted the branch on Apr 23, 2018
  13. jasonbcox referenced this in commit 51fbdf464a on Sep 13, 2019
  14. jonspock referenced this in commit 0b37364768 on Dec 22, 2019
  15. proteanx referenced this in commit 4160fc5dab on Dec 23, 2019
  16. PastaPastaPasta referenced this in commit 5f4792e9c2 on Nov 10, 2020
  17. PastaPastaPasta referenced this in commit fa1bad1208 on Nov 12, 2020
  18. PastaPastaPasta referenced this in commit 82cb32f1d3 on Nov 17, 2020
  19. MarcoFalke locked this on Sep 8, 2021
Contributors
Empactpracticalswiftlaanwjjonasschnelli
Labels
Utils/log/libs
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me