Fix include comment in src/interfaces/wallet.h #13026

pull promag wants to merge 1 commits into bitcoin:master from promag:2018-04-fixincludecomment changing 1 files +1 −1

promag commented at 9:16 AM on April 19, 2018: member

No description provided.
fanquake added the label Docs on Apr 19, 2018
trivial: Improve include comment in src/interfaces/wallet.h defffb3587
in src/interfaces/wallet.h:9 in a962c5440e outdated
```
   5 | @@ -6,7 +6,7 @@
   6 |  #define BITCOIN_INTERFACES_WALLET_H
   7 |  
   8 |  #include <amount.h>                    // For CAmount
   9 | -#include <pubkey.h>                    // For CTxDestination (CKeyID and CScriptID)
  10 | +#include <pubkey.h>                    // For CKeyID, CPubKey
```
ryanofsky commented at 11:21 AM on April 19, 2018:

Previous comment was actually correct, though for clarity I might change it to // For CKeyID and CScriptID (definitions needed in CTxDestination instantiation).

New comment is misleading because includes are only used here for things that can't be forward declared, and the only reason CKeyID and CScriptID can't be forward declared is because CTxDestination is instantiated as a struct member on line 277.
promag force-pushed on Apr 19, 2018
promag commented at 1:33 PM on April 19, 2018: member

@ryanofsky Sorry if I've overlooked. Now with your suggestion.
practicalswift commented at 1:56 PM on April 19, 2018: contributor

ACK defffb3587ebb1cda5331ac1e229a34472f29ddb
ryanofsky commented at 3:13 PM on April 19, 2018: member

utACK defffb3587ebb1cda5331ac1e229a34472f29ddb
MarcoFalke merged this on Apr 19, 2018
MarcoFalke closed this on Apr 19, 2018
MarcoFalke referenced this in commit 9b3a67eb08 on Apr 19, 2018
Fabcien referenced this in commit 613c7d2024 on Aug 30, 2019
PastaPastaPasta referenced this in commit 6901842b9f on Nov 10, 2020
PastaPastaPasta referenced this in commit 7ed552674a on Nov 12, 2020
PastaPastaPasta referenced this in commit 9910a1269b on Nov 17, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels