Add compile time checking for all cs_KeyStore runtime locking assertions #13077

1. 
   practicalswift commented at 8:32 pm on April 25, 2018: contributor

   Add compile time checking for all cs_KeyStore runtime locking assertions.

   This PR is a subset of #12665. The PR was broken up to make reviewing easier.

   The intention is that literally all EXCLUSIVE_LOCKS_REQUIRED/LOCKS_EXCLUDED:s added in this PR should follow either directly or indirectly from AssertLockHeld(…)/AssertLockNotHeld(…):s already existing in the repo.

   Consider the case where function A(…) contains AssertLockHeld(cs_foo) (without first locking cs_foo in A), and that B(…) calls A(…) (without first locking cs_main):

   • It directly follows that: A(…) should have an EXCLUSIVE_LOCKS_REQUIRED(cs_foo) annotation.
   • It indirectly follows that: B(…) should have an EXCLUSIVE_LOCKS_REQUIRED(cs_foo) annotation.
2. Add compile time checking for all cs_KeyStore runtime locking assertions 66dc662c8a
3. fanquake added the label Refactoring on Apr 25, 2018
4. 
   MarcoFalke commented at 9:55 pm on April 26, 2018: member

   utACK 66dc662c8aa5d7a178451f5ad5d826552693158c (seems a trivial one-line patch)
5. 
   TheBlueMatt commented at 0:07 am on April 28, 2018: member

   utACK 66dc662c8aa5d7a178451f5ad5d826552693158c
6. MarcoFalke merged this on Apr 28, 2018
7. MarcoFalke closed this on Apr 28, 2018

   ---

8. MarcoFalke referenced this in commit 3315007e03 on Apr 28, 2018
9. jasonbcox referenced this in commit 69b14ee35a on Sep 13, 2019
10. jonspock referenced this in commit 72aa060590 on Dec 22, 2019
11. proteanx referenced this in commit 926bf1f468 on Dec 23, 2019
12. practicalswift deleted the branch on Apr 10, 2021
13. DrahtBot locked this on Aug 16, 2022

Contributors
practicalswift MarcoFalke TheBlueMatt

Labels
Refactoring