[WIP] contrib: Remove distribution packaging #13137

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2018_05_move_distro_packaging changing 33 files +2 −1958
  1. laanwj commented at 4:19 PM on May 1, 2018: member

    This has been moved to a separate repository, https://github.com/bitcoin-core/packaging

    TODO need to find a distribution agnostic place, (somewhere under share?) for:

    • assets-attribution (../contrib/debian/copyright)
    • example configuration file contrib/debian/examples/bitcoin.conf
  2. laanwj added the label Build system on May 1, 2018
  3. laanwj force-pushed on May 1, 2018
  4. MarcoFalke commented at 4:22 PM on May 1, 2018: member

    Concept ACK

  5. flack commented at 4:58 PM on May 1, 2018: contributor

    Just did a quick search for contrib/debian, and it's still referenced and these files:

    https://github.com/bitcoin/bitcoin/blob/master/doc/assets-attribution.md https://github.com/bitcoin/bitcoin/blob/master/doc/init.md https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md

    These should probably be updated here as well. Also, https://github.com/bitcoin/bitcoin/blob/master/Makefile.am contains a reference to contrib/rpm, not sure if that's a problem

  6. laanwj commented at 6:13 PM on May 1, 2018: member

    @flack thanks, yes, those should be updated as well

  7. luke-jr commented at 7:18 PM on May 1, 2018: member

    I think it is much better to maintain this in the same repo, especially since the debian/ dir has things useful in general.

  8. laanwj commented at 1:00 AM on May 2, 2018: member

    According to @thebluematt it's out of date half of the time anyway. If it's not kept in sync with releases there's no reason to keep it in the main repository.

    especially since the debian/ dir has things useful in general.

    In that case, we should make sure it's moved somewhere else.

    I agree that we've salvaged generally useful parts from there before (though at least the man-pages had license issues preventing that), but for something that is useful in general, a distribution-packaging specific directory is not the place. (I've repeatedly commented this about the desktop file, also that it should be installed with make install)

  9. contrib: Remove distribution packaging
    This has been moved to a separate repository,
    https://github.com/bitcoin-core/packaging
    35a21f92d5
  10. laanwj force-pushed on May 2, 2018
  11. meshcollider commented at 8:52 AM on May 2, 2018: contributor

    Concept ACK

  12. practicalswift commented at 10:41 AM on May 2, 2018: contributor

    Concept ACK

  13. MarcoFalke commented at 1:15 PM on May 2, 2018: member

    Re "assets-attribution":

    We are only talking about qt stuff in ./src/qt/res and share/pixmaps/, so I think it is fine to just amend the Readme in those folders to include the copyright notices. (This way we don't have to do it a third time, when the gui is moved out of this repo)

  14. laanwj renamed this:
    contrib: Remove distribution packaging
    [WIP] contrib: Remove distribution packaging
    on May 2, 2018
  15. MarcoFalke commented at 2:15 PM on May 16, 2018: member

    Needs rebase and feedback addressed

  16. MarcoFalke added the label Needs rebase on Jun 6, 2018
  17. MarcoFalke commented at 6:50 PM on July 30, 2018: member

    See #13809

  18. MarcoFalke closed this on Jul 30, 2018

  19. laanwj removed the label Needs rebase on Oct 24, 2019
  20. MarcoFalke locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me