[travis] New travis job for CHECK_DOCS steps #13183

pull glaksmono wants to merge 1 commits into bitcoin:master from glaksmono:bitcoin-11004 changing 1 files +29 −14
  1. glaksmono commented at 10:28 AM on May 7, 2018: contributor

    Configure a new Travis job that runs against PRs, and only runs the CHECK_DOC tests. At the same time, the CHECK_DOC stuff in the existing job would be removed.

    Fixes #11004

  2. fanquake added the label Tests on May 7, 2018
  3. glaksmono force-pushed on May 7, 2018
  4. glaksmono force-pushed on May 7, 2018
  5. glaksmono force-pushed on May 7, 2018
  6. in .travis.yml:78 in d4ccec806b outdated 
      69 | @@ -84,3 +70,24 @@ script:
  70 |  after_script:
  71 |      - echo $TRAVIS_COMMIT_RANGE
  72 |      - echo $TRAVIS_COMMIT_LOG
  73 | +
  74 | +jobs:
  75 | +  include:
  76 | +    - stage: CHECK_DOC
  77 | +      env:
  78 | +        - HOST=arm-linux-gnueabihf PACKAGES="g++-arm-linux-gnueabihf python3-pip shellcheck" DEP_OPTS="NO_QT=1" CHECK_DOC=1 GOAL="install" BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports"
    MarcoFalke commented at 2:15 PM on May 7, 2018:

    Please keep the actual arm cross build intact. The only thing you'd need to move here is the pip and shellcheck package

    Also, would be nice if the check doc run before the tests, not the other way round.

    glaksmono commented at 2:42 PM on May 7, 2018:

    HOST=arm-linux-gnueabihf will be executed twice in the check_doc and test then?

  7. MarcoFalke renamed this:
    [WIP][bitcoin-11004] New Travis job for CHECK_DOCS steps
    [WIP] New Travis job for CHECK_DOCS steps
    on May 7, 2018
  8. glaksmono force-pushed on May 7, 2018
  9. glaksmono force-pushed on May 7, 2018
  10. glaksmono force-pushed on May 7, 2018
  11. MarcoFalke commented at 2:53 PM on May 7, 2018: member

    You wouldn't need to set environment variables that are not used for the check doc. I.e. no need for the cross compile HOST ...

    On Mon, May 7, 2018, 10:43 Grady Laksmono notifications@github.com wrote:

    @glaksmono commented on this pull request.

    In .travis.yml https://github.com/bitcoin/bitcoin/pull/13183#discussion_r186444769:

    @@ -84,3 +70,24 @@ script: after_script: - echo $TRAVIS_COMMIT_RANGE - echo $TRAVIS_COMMIT_LOG

    • +jobs:
    • include:
      • stage: CHECK_DOC
    •  env:
    •    - HOST=arm-linux-gnueabihf PACKAGES="g++-arm-linux-gnueabihf python3-pip shellcheck" DEP_OPTS="NO_QT=1" CHECK_DOC=1 GOAL="install" BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports"

    HOST=arm-linux-gnueabihf will be executed twice in the check_doc and test then?

    — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/13183#discussion_r186444769, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv2lQYTRAB2bg70MXl0ugLJVNhLGeks5twF2agaJpZM4T0v_5 .

  12. glaksmono force-pushed on May 7, 2018
  13. in .travis.yml:84 in a110c6aa5d outdated 
      79 | +jobs:
  80 | +  include:
  81 | +    - stage: check_doc
  82 | +      sudo: required
  83 | +      env:
  84 | +        - PACKAGES="python3-pip shellcheck" CHECK_DOC=1
    MarcoFalke commented at 3:02 PM on May 7, 2018:

    Can remove CHECK_DOC here

  14. in .travis.yml:28 in a110c6aa5d outdated 
      24 | @@ -22,7 +25,7 @@ env:
  25 |      - WINEDEBUG=fixme-all
  26 |    matrix:
  27 |  # ARM
  28 | -    - HOST=arm-linux-gnueabihf PACKAGES="g++-arm-linux-gnueabihf python3-pip shellcheck" DEP_OPTS="NO_QT=1" CHECK_DOC=1 GOAL="install" BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports"
  29 | +    - HOST=arm-linux-gnueabihf PACKAGES="g++-arm-linux-gnueabihf python3-pip shellcheck" DEP_OPTS="NO_QT=1" GOAL="install" BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports"
    MarcoFalke commented at 3:02 PM on May 7, 2018:

    can remove pip and shellcheck here

  15. glaksmono force-pushed on May 7, 2018
  16. in .travis.yml:82 in 56b05297d4 outdated 
      74 | @@ -84,3 +75,27 @@ script:
  75 |  after_script:
  76 |      - echo $TRAVIS_COMMIT_RANGE
  77 |      - echo $TRAVIS_COMMIT_LOG
  78 | +
  79 | +jobs:
  80 | +  include:
  81 | +    - stage: check_doc
  82 | +      sudo: required
    MarcoFalke commented at 4:29 PM on May 7, 2018:

    You can get rid of sudo here to speed up the boot-process:

    diff --git a/.travis.yml b/.travis.yml
index f3f5305e4a..f547b3dc42 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -79,12 +79,13 @@ after_script:
 jobs:
   include:
     - stage: check_doc
-      sudo: required
-      env:
-        - PACKAGES="python3-pip shellcheck"
+      sudo: false
+      addons:
+       apt:
+        packages:
+         - python3-pip
+         - shellcheck
       install:
-        - if [ -n "$PACKAGES" ]; then travis_retry sudo apt-get update; fi
-        - if [ -n "$PACKAGES" ]; then travis_retry sudo apt-get install --no-install-recommends --no-upgrade -qq $PACKAGES; fi
         - if [ "$TRAVIS_EVENT_TYPE" = "pull_request" ]; then travis_retry pip3 install flake8 --user; fi
       before_script:
         - git fetch --unshallow
  17. in .travis.yml:16 in 56b05297d4 outdated 
       7 | @@ -8,6 +8,9 @@ cache:
   8 |    - depends/built
   9 |    - depends/sdk-sources
  10 |    - $HOME/.ccache
  11 | +stages:
  12 | +  - check_doc
  13 | +  - test
  14 |  env:
  15 |    global:
  16 |      - MAKEJOBS=-j3
    MarcoFalke commented at 4:32 PM on May 7, 2018:

    Can remove the CHECK_DOC on the line below this one.

    glaksmono commented at 12:29 AM on May 8, 2018:

    Done

  18. glaksmono force-pushed on May 8, 2018
  19. in .travis.yml:80 in 4985eb5034 outdated 
      73 | @@ -84,3 +74,26 @@ script:
  74 |  after_script:
  75 |      - echo $TRAVIS_COMMIT_RANGE
  76 |      - echo $TRAVIS_COMMIT_LOG
  77 | +
  78 | +jobs:
  79 | +  include:
  80 | +    - stage: check_doc
    ken2812221 commented at 12:47 AM on May 8, 2018:

    How about add sudo: false here, travis can boot faster Seems not work.

    MarcoFalke commented at 2:32 PM on May 8, 2018:

    Please see my previous diff to get it to work

    MarcoFalke commented at 2:32 PM on May 8, 2018:

    #13183 (review)

    glaksmono commented at 1:47 AM on May 9, 2018:

    Done

  20. ken2812221 commented at 4:44 AM on May 8, 2018: contributor

    Concept ACK

  21. MarcoFalke renamed this:
    [WIP] New Travis job for CHECK_DOCS steps
    [travis] New travis job for CHECK_DOCS steps
    on May 8, 2018
  22. MarcoFalke commented at 1:38 AM on May 9, 2018: member

    Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

  23. [bitcoin-11004] creating another jobs for the CHECK_DOC=1, separated from the core jobs 18c0b84308
  24. glaksmono force-pushed on May 9, 2018
  25. ken2812221 approved
  26. ken2812221 commented at 1:57 AM on May 9, 2018: contributor

    utACK 372e8e95aaae449df3f7d2197e1b2f54288a1fbe

  27. MarcoFalke commented at 2:09 AM on May 9, 2018: member

    utACK 18c0b8430820114d14a15fe19b7ae86e62be17d8. Thanks for sticking with this. Indeed a very nice first contribution!

  28. glaksmono commented at 2:14 AM on May 9, 2018: contributor

    Thank you for all of the guidance @MarcoFalke

  29. sipa commented at 3:39 AM on May 9, 2018: member

    utACK 18c0b8430820114d14a15fe19b7ae86e62be17d8

  30. ken2812221 commented at 4:05 AM on May 9, 2018: contributor

    re-utACK 18c0b8430820114d14a15fe19b7ae86e62be17d8

  31. fanquake deleted a comment on May 9, 2018
  32. laanwj merged this on May 9, 2018
  33. laanwj closed this on May 9, 2018
  34. laanwj referenced this in commit 9458b05f28 on May 9, 2018
  35. practicalswift commented at 8:41 AM on May 9, 2018: contributor

    Thanks @glaksmono! Very nice contribution!

  36. glaksmono deleted the branch on May 9, 2018
  37. TheArbitrator referenced this in commit d0ffee9e4c on Jun 7, 2021
  38. MarcoFalke locked this on Sep 8, 2021
Contributors
glaksmonoMarcoFalkeken2812221sipapracticalswift
Labels
Tests
Linked (view graph)
#11004 New Travis job for CHECK_DOCS steps
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-29 03:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me